| Message ID | 20231224143850.5671-3-josua@solid-run.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm: dts: marvell: clearfog-gtr: miscellaneous enhancements | expand |
On 24/12/2023 15:38, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 > boards. > > Signed-off-by: Josua Mayer <josua@solid-run.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. > --- > .../devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > index 5af222e6db18..5bc69c4fe34d 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -30,4 +30,12 @@ properties: > - const: marvell,armada385 > - const: marvell,armada380 > > + - description: SolidRun Armada 385 based single-board computers > + items: > + - enum: > + - solidrun,clearfog-gtr-l8 > + - solidrun,clearfog-gtr-s4 Not tested. This will fail and if you bothered to Cc lists, at least automation would test it for you. Now, neither you nor automation will tell it does not work :( Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml index 5af222e6db18..5bc69c4fe34d 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml @@ -30,4 +30,12 @@ properties: - const: marvell,armada385 - const: marvell,armada380 + - description: SolidRun Armada 385 based single-board computers + items: + - enum: + - solidrun,clearfog-gtr-l8 + - solidrun,clearfog-gtr-s4 + - const: marvell,armada385 + - const: marvell,armada380 + additionalProperties: true
Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 boards. Signed-off-by: Josua Mayer <josua@solid-run.com> --- .../devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)