| Message ID | 20231227130812.148914-1-eugen.hristev@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count | expand |
Il 27/12/23 14:08, Eugen Hristev ha scritto: > MT8186 has 4 iommus in the list, to cope with this situation, adjust > the maxItems to 4 (instead of previous 2). > Add also minItems as 1 since iommus are mandatory, to avoid warning > on the example. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > .../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > index 37800e1908cc..60c75b9312e8 100644 > --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml > @@ -38,7 +38,8 @@ properties: > maxItems: 1 > > iommus: > - maxItems: 2 > + minItems: 1 > + maxItems: 4 > description: | > Points to the respective IOMMU block with master port as argument, see > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. (commit title) `ioomus` is something I've never heard of before... :-P Please fix the typo, after which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: > MT8186 has 4 iommus in the list, to cope with this situation, adjust > the maxItems to 4 (instead of previous 2). > Add also minItems as 1 since iommus are mandatory, to avoid warning > on the example. maxItems alone means minItems is the same size. If IOMMU is required, then 'required' is where that is defined. Is there a case where 1 IOMMU is valid? If so, what h/w has this case. Rob
On 1/9/24 05:27, Rob Herring wrote: > On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: >> MT8186 has 4 iommus in the list, to cope with this situation, adjust >> the maxItems to 4 (instead of previous 2). >> Add also minItems as 1 since iommus are mandatory, to avoid warning >> on the example. > > maxItems alone means minItems is the same size. If IOMMU is required, > then 'required' is where that is defined. Is there a case where 1 IOMMU > is valid? If so, what h/w has this case. > > Rob > > Hello Rob, Without setting a minItems , the example in the binding fails, because it has just 2 items, while the maxItems is now 4. I set minItems as 1 to avoid restricting any kind of hardware to have at least 2 items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2. Is that fine with you ? Eugen
On 15/01/2024 04:57, Eugen Hristev wrote: > On 1/9/24 05:27, Rob Herring wrote: >> On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote: >>> MT8186 has 4 iommus in the list, to cope with this situation, adjust >>> the maxItems to 4 (instead of previous 2). >>> Add also minItems as 1 since iommus are mandatory, to avoid warning >>> on the example. >> >> maxItems alone means minItems is the same size. If IOMMU is required, >> then 'required' is where that is defined. Is there a case where 1 IOMMU >> is valid? If so, what h/w has this case. >> >> Rob >> >> > > Hello Rob, > > Without setting a minItems , the example in the binding fails, because it has just > 2 items, while the maxItems is now 4. > I set minItems as 1 to avoid restricting any kind of hardware to have at least 2 > items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2. > Is that fine with you ? > I think that's what you should do yes. If in the future there shows up a platform with just one iommu, then we can fix that. Regards, Matthias
diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml index 37800e1908cc..60c75b9312e8 100644 --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml @@ -38,7 +38,8 @@ properties: maxItems: 1 iommus: - maxItems: 2 + minItems: 1 + maxItems: 4 description: | Points to the respective IOMMU block with master port as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
MT8186 has 4 iommus in the list, to cope with this situation, adjust the maxItems to 4 (instead of previous 2). Add also minItems as 1 since iommus are mandatory, to avoid warning on the example. Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- .../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)