From patchwork Wed Jan 3 14:12:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13510654 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA4C4C3DA6E for ; Wed, 3 Jan 2024 23:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SUC2xeJz0yBha7c6fhzb3/xhtq+YEeEgFk4iMm+SRmg=; b=HcoWqbwi+qVg++ /1uXakYtIdgxCzcJGo9QtrKzCfErK91nX4fRxiihMzvMwpYGT4IJ+QD2g3VMhuWcxb9gyysHm0gHb juWkiIynNh7nXzrWpIIl3d4lKr7gotyIHQovv252yNjPe2M0Hfgds4Xk49HCB8YbeXOulc7aOxCOo 1BbO3GedqL2KXqup5JN5CBs6h++InBjf2ueQ6R6dal+I/lr2gNFyInYdtSwGZ0rJmITkLlMzxtSpo p1XkQs0fpaH6zNz1FmVpXGdxMotxUUf3CAtOcMoze1dwooHuQ7xDXI5exIL8fCxd3MBvT0kFuKYjf HcJk+PEQJJUqbM3UqwOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLAIJ-00CMQU-2A; Wed, 03 Jan 2024 23:05:03 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLAIG-00CMNN-2A for linux-arm-kernel@lists.infradead.org; Wed, 03 Jan 2024 23:05:02 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40d89446895so5854755e9.0 for ; Wed, 03 Jan 2024 15:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704323098; x=1704927898; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fQabVWmpmoZU8yQyfqwraJ/6CaCvr56KIOoajwAPETc=; b=niBLEKY6AKDk2FOWBrsU4AGgILm++5du8pa/ExmywlCjpv7fzTjMdt89uu4etYdyYr KSoJc8OjLJBvq3Tn8cOc7+3tXXTCmCEUzvZ4TQ/qFu90nD01pHxO9SwpmjHcsa3ab7++ G820ffL7L56s3dCFOhJ0XEHY20HuX3fsYMecCSGgCgOesg8qiPpdTgUHaVRQ/+sSh62B SgA9ItpyQtsjcuDV2hMUUDEM0OvKMlRWhDYVCXMiEeAdzgleynGgS2z5TGU+XzTOjvJn hObNJ1JZPd575EYaPhPM+iy4K+7WQf8eMnH1VOU8/U/O4BVh7bjxxagtR8B/FftHXN8D 0GmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704323098; x=1704927898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fQabVWmpmoZU8yQyfqwraJ/6CaCvr56KIOoajwAPETc=; b=neQ08aQILs+KQvD9P+iS9IUWK2dXqw9OefL2rxrjzd3gj2sNbgVKr47ku+TS0nel9U VnwfXLA0EAgcnyk1IydJEBzFcB0qCaZom6cNJVyoafnGx2ZaR6hR/uDO0JkAXI40hOLa nUbZxaWC7+f6XkGy5W5vjWQTCgV/DUZzM1BvTdhLjf16sGQxvVjSIMUuMuNdD3u/l44y JdeQ08kT0BK46eurp9e5QOmJYoduTN0tT6FaVsrK+vvZ26flfAawI0/ti+D19dt9N8Z+ NGZ+/tDgHP1JCU4Kd/tpRH6Grv2WfNSVNrFxQ2OYyD7SynOeJHYyMlijQanxqK78CQKA Ul8g== X-Gm-Message-State: AOJu0YwLcWMKpFuCCSNoZrdUCkVJMbpXG3y1/gCwi9twzSoSphvh8WVp ghQoQNDcDanZ96+NbCIih3H5tbNJM/s= X-Google-Smtp-Source: AGHT+IEISrlEqHRrW/K5DonT/q6LvZTnvXJR8+etSCMcMD15Rp6nle4ldjMSNCtJ7gs908viVsaVuA== X-Received: by 2002:a05:600c:2a4e:b0:40d:8f7a:9f9e with SMTP id x14-20020a05600c2a4e00b0040d8f7a9f9emr934834wme.73.1704323098376; Wed, 03 Jan 2024 15:04:58 -0800 (PST) Received: from localhost.localdomain (host-80-116-159-187.retail.telecomitalia.it. [80.116.159.187]) by smtp.googlemail.com with ESMTPSA id w13-20020a05600c474d00b0040c46719966sm3740969wmo.25.2024.01.03.15.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 15:04:57 -0800 (PST) From: Christian Marangi To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?b?UmFmYcWCIE1p?= =?utf-8?b?xYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , Jacek Anaszewski , =?utf-8?q?Fern=C3=A1ndez_Roj?= =?utf-8?q?as?= , Sven Schwermer , Christian Marangi , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [net-next PATCH v7 3/5] net: phy: add support for PHY LEDs polarity modes Date: Wed, 3 Jan 2024 15:12:36 +0100 Message-ID: <20240103141251.23446-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240103141251.23446-1-ansuelsmth@gmail.com> References: <20240103141251.23446-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_150500_712774_BDB73F47 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add support for PHY LEDs polarity modes. Some PHY require LED to be set to active low to be turned ON. Adds support for this by declaring active-low property in DT. PHY driver needs to declare .led_polarity_set() to configure LED polarity modes. Function will pass the index with the LED index and a bitmap with all the required modes to set. Current supported modes are: - active-low with the flag PHY_LED_ACTIVE_LOW. LED is set to active-low to turn it ON. - inactive-high-impedance with the flag PHY_LED_INACTIVE_HIGH_IMPEDANCE. LED is set to high impedance to turn it OFF. Signed-off-by: Christian Marangi --- Changes v5: - Rework to LED modes bitmap Changes v4: - Drop for global active-low - Rework to polarity option (for marvell10g series support) Changes v3: - Out of RFC Changes v2: - Add this patch drivers/net/phy/phy_device.c | 12 ++++++++++++ include/linux/phy.h | 22 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 1e595762afea..437a1c6046ab 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -3152,6 +3152,7 @@ static int of_phy_led(struct phy_device *phydev, struct device *dev = &phydev->mdio.dev; struct led_init_data init_data = {}; struct led_classdev *cdev; + unsigned long modes = 0; struct phy_led *phyled; u32 index; int err; @@ -3169,6 +3170,17 @@ static int of_phy_led(struct phy_device *phydev, if (index > U8_MAX) return -EINVAL; + if (phydev->drv->led_polarity_set) { + if (of_property_read_bool(led, "active-low")) + set_bit(PHY_LED_ACTIVE_LOW, &modes); + if (of_property_read_bool(led, "inactive-high-impedance")) + set_bit(PHY_LED_INACTIVE_HIGH_IMPEDANCE, &modes); + + err = phydev->drv->led_polarity_set(phydev, index, modes); + if (err) + return err; + } + phyled->index = index; if (phydev->drv->led_brightness_set) cdev->brightness_set_blocking = phy_led_set_brightness; diff --git a/include/linux/phy.h b/include/linux/phy.h index ac22b8e28a85..da0a15a6d638 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -860,6 +860,15 @@ struct phy_plca_status { bool pst; }; +/* Modes for PHY LED configuration */ +enum phy_led_modes { + PHY_LED_ACTIVE_LOW = 0, + PHY_LED_INACTIVE_HIGH_IMPEDANCE = 1, + + /* keep it last */ + __PHY_LED_MODES_NUM, +}; + /** * struct phy_led: An LED driven by the PHY * @@ -1153,6 +1162,19 @@ struct phy_driver { int (*led_hw_control_get)(struct phy_device *dev, u8 index, unsigned long *rules); + /** + * @led_polarity_set: Set the LED polarity if active low + * @dev: PHY device which has the LED + * @index: Which LED of the PHY device or -1 + * @modes: bitmap of LED polarity modes + * + * Configure LED with all the required polarity modes in @modes + * to make it correctly turn ON or OFF. + * + * Returns 0, or an error code. + */ + int (*led_polarity_set)(struct phy_device *dev, int index, + unsigned long modes); }; #define to_phy_driver(d) container_of(to_mdio_common_driver(d), \ struct phy_driver, mdiodrv)