| Message ID | 20240103142051.111717-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: thermal: correct thermal zone node name limit | expand |
On Wed, Jan 3, 2024 at 7:21 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Linux kernel uses thermal zone node name during registering thermal > zones and has a hard-coded limit of 20 characters, including terminating > NUL byte. Exceeding the limit will cause failure to configure thermal > zone. > > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/all/CAL_JsqKogbT_4DPd1n94xqeHaU_J8ve5K09WOyVsRX3jxxUW3w@mail.gmail.com/ > Fixes: fb4d25d7a33f ("arm64: dts: juno: Align thermal zone names with bindings") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- > arch/arm64/boot/dts/arm/juno-scmi.dtsi | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, 03 Jan 2024 15:20:51 +0100, Krzysztof Kozlowski wrote: > Linux kernel uses thermal zone node name during registering thermal > zones and has a hard-coded limit of 20 characters, including terminating > NUL byte. Exceeding the limit will cause failure to configure thermal > zone. > > Applied, thanks! This was waiting on the lists for some time and no one picked it up, so... let me know if I should drop it from my tree. [2/2] arm64: dts: juno: fix thermal zone node names https://git.kernel.org/krzk/linux-dt/c/85170635525758828dc22be83f6b17a86ccec312 Best regards,
On Mon, Mar 25, 2024 at 12:05:14PM +0100, Krzysztof Kozlowski wrote: > > On Wed, 03 Jan 2024 15:20:51 +0100, Krzysztof Kozlowski wrote: > > Linux kernel uses thermal zone node name during registering thermal > > zones and has a hard-coded limit of 20 characters, including terminating > > NUL byte. Exceeding the limit will cause failure to configure thermal > > zone. > > > > > > Applied, thanks! > > This was waiting on the lists for some time and no one picked it up, so... let > me know if I should drop it from my tree. > Sorry for that, must have slipped through when I was off. Thanks for picking it up. If not too late, feel free to add Acked-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index b897f5542c0a..98ed2b329ed6 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -773,14 +773,14 @@ soc_crit0: trip0 { }; }; - big_cluster_thermal_zone: big-cluster-thermal { + big_cluster_thermal_zone: big-cl-thermal { polling-delay = <1000>; polling-delay-passive = <100>; thermal-sensors = <&scpi_sensors0 21>; status = "disabled"; }; - little_cluster_thermal_zone: little-cluster-thermal { + little_cluster_thermal_zone: little-cl-thermal { polling-delay = <1000>; polling-delay-passive = <100>; thermal-sensors = <&scpi_sensors0 22>; diff --git a/arch/arm64/boot/dts/arm/juno-scmi.dtsi b/arch/arm64/boot/dts/arm/juno-scmi.dtsi index 31929e2377d8..f38c5b6ef657 100644 --- a/arch/arm64/boot/dts/arm/juno-scmi.dtsi +++ b/arch/arm64/boot/dts/arm/juno-scmi.dtsi @@ -84,11 +84,11 @@ soc-thermal { thermal-sensors = <&scmi_sensors0 3>; }; - big-cluster-thermal { + big-cl-thermal { thermal-sensors = <&scmi_sensors0 21>; }; - little-cluster-thermal { + little-cl-thermal { thermal-sensors = <&scmi_sensors0 22>; };
Linux kernel uses thermal zone node name during registering thermal zones and has a hard-coded limit of 20 characters, including terminating NUL byte. Exceeding the limit will cause failure to configure thermal zone. Reported-by: Rob Herring <robh@kernel.org> Closes: https://lore.kernel.org/all/CAL_JsqKogbT_4DPd1n94xqeHaU_J8ve5K09WOyVsRX3jxxUW3w@mail.gmail.com/ Fixes: fb4d25d7a33f ("arm64: dts: juno: Align thermal zone names with bindings") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- arch/arm64/boot/dts/arm/juno-scmi.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)