From patchwork Tue Jan 9 16:46:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13515089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDC30C47077 for ; Tue, 9 Jan 2024 16:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcRKL2zi5Ay+lWAC3Zw42MbBBNKbBwE9chpDVwDxdGA=; b=bTKVCt2yqbq40+ 6f4CVr9gNioZuOihfwSGpyT6gSVP8LX2bSoL8bcKYvEjv74QWwwXYd0Y9yUj5t9Vs+LrQ8SF6XRmD HcTtE+a4dgPtX/j9t+Hj/QZS72qFldGSrkSHN85E4mfrIC+CwnqvwgzrGny5Cdi6SLo9SHroDF6eq mZgJncS6+xpHTRD5wqxVUQfa5eyxT2U7l3PD66NlT7aPgT4kTbcOP9Q8J4wRym7neQk3aMCDe0hLs tkGlQbMpHpOaysXPzZTMjUTR7wGjiuMeEK0aRLPK4FWQ7nu3J7T4l4B40f12c3PZbN9eWmXzbJjP1 PiMT8XFWtPZ4vlOYZL+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNFFy-008tNA-2o; Tue, 09 Jan 2024 16:47:14 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNFFs-008tH9-0f for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 16:47:11 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3373a30af67so3014344f8f.0 for ; Tue, 09 Jan 2024 08:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704818824; x=1705423624; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=S1uiL8g6TYtUWh7x6ZLivs7SS72OVhB40UK477rasdszVNGTjr0P3Oi+9qKIMV0Cdc 8jpmbxOwPHDuRnRovuZTrwdULenbbb9k/vF6dNE2+KoI/lVzk7hWnZkWOv5qOB7qTONO UlczE8CWOOgjWjVbRxcnWzculp9IGXtmFIvE9ktZFu2Rrl97c7krMMjZwdbw8/jsQ/4M FtRliQUjkK7oBjF1zmn2SeuA4z1kLKkxetsDktdwmMFXylciIIDUNvyYqjTWb8cwThBB I9fy7XL7km/eE++wy4nfi91+PXTrzy6V6PbOzfazjPvkVY4C6gcRu6oA4x8PyJjHtyww jQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704818824; x=1705423624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJN21V1bop2AoQQK03hl+NSFZtBSAxp4abYemrkmzIE=; b=Jo4Xpw3TZ4GlCBZSdAubzANSAEYDf+vPHqRk9RJg9QXBEytFaEb/5TxPRgucMmXIb9 fxEKxZdX7Oz+ArCDWSa4PRtiIT/AUolxVOEyLMiFzqDZ3eI+FrBgZDC9ah2q5BaiGogZ qDhYyDjtj4TK8xgNLNH495OSanjPOfkN10NvZ2dC5VJLrBhq/tKlvwySYeIX9vj8HOx6 t4UVTEgWAyFxtHyWRFZQezgjfR0wsRyJlf61JM0unxOU5uZTEldq84mciypWE+cmpiIW /sDlmFKX4tXtXStqzKnolfh0/eku0C35fG5yfC7sSbTTtbNwo2hHVudQ8zUI5r0CY373 rWqg== X-Gm-Message-State: AOJu0YyhfH3L9J4UQ45GoPaagnPg5yhg8F/w/b3EUILs8KnAt3aNtUM/ 3IXJ69ou+NvXvF1OQtfwgVNYw8lwBimDXg== X-Google-Smtp-Source: AGHT+IEvlNytvVJlvTPpPwPO+qKiZL8zyQNEs4mDtfVfHwEckXosl+y6Ud/itCsffCbRJB9ZysRO4g== X-Received: by 2002:a5d:6b02:0:b0:336:c403:56dd with SMTP id v2-20020a5d6b02000000b00336c40356ddmr399099wrw.150.1704818824462; Tue, 09 Jan 2024 08:47:04 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:378:51f6:d46e:8457]) by smtp.gmail.com with ESMTPSA id r4-20020adff104000000b00336a0c083easm2847845wro.53.2024.01.09.08.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 08:47:03 -0800 (PST) From: Vincent Guittot To: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: qyousef@layalina.io, Vincent Guittot Subject: [PATCH v4 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Tue, 9 Jan 2024 17:46:53 +0100 Message-Id: <20240109164655.626085-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240109164655.626085-1-vincent.guittot@linaro.org> References: <20240109164655.626085-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_084708_284811_FBAD894D X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Acked-by: Viresh Kumar --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }