| Message ID | 20240110074007.4020016-1-tudor.ambarus@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: irq: include <linux/cpumask.h> | expand |
Quoting Tudor Ambarus (2024-01-09 23:40:07) > Sorting include files in alphabetic order in > drivers/tty/serial/samsung.c revealed the following error: > > In file included from drivers/tty/serial/samsung_tty.c:24: > ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name ‘cpumask_t’ > 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); > | ^~~~~~~~~ > > Include cpumask.h to avoid unknown type errors for parents of irq.h that > don't include cpumask.h. > > Acked-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Wed, 10 Jan 2024 07:40:07 +0000, Tudor Ambarus wrote: > Sorting include files in alphabetic order in > drivers/tty/serial/samsung.c revealed the following error: > > In file included from drivers/tty/serial/samsung_tty.c:24: > ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name ‘cpumask_t’ > 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); > | ^~~~~~~~~ > > [...] Applied to arm64 (for-next/core), thanks! [1/1] arm64: irq: include <linux/cpumask.h> https://git.kernel.org/arm64/c/b95df3bd1ea3 Cheers,
diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h index 50ce8b697ff3..e93548914c36 100644 --- a/arch/arm64/include/asm/irq.h +++ b/arch/arm64/include/asm/irq.h @@ -4,6 +4,8 @@ #ifndef __ASSEMBLER__ +#include <linux/cpumask.h> + #include <asm-generic/irq.h> void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu);
Sorting include files in alphabetic order in drivers/tty/serial/samsung.c revealed the following error: In file included from drivers/tty/serial/samsung_tty.c:24: ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name ‘cpumask_t’ 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); | ^~~~~~~~~ Include cpumask.h to avoid unknown type errors for parents of irq.h that don't include cpumask.h. Acked-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- v2: - fix typo, s/avod/avoid - include the linux header first and then add a new line to differentiate from the asm header - collect Mark's Acked-by tag arch/arm64/include/asm/irq.h | 2 ++ 1 file changed, 2 insertions(+)