| Message ID | 20240110100526.478771-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible | expand |
On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > Now that there is a dedicated compatible for the idendification page use > that instead. This also allows the removal the size and pagesize > properties. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thanks!
On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > Now that there is a dedicated compatible for the idendification page use > that instead. This also allows the removal the size and pagesize > properties. This commit message fails to answer Why? And fails to mention the ABI break. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > index f6e422dc2663e..9d2328c185c90 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { > > /* protectable identification memory (part of M24C64-D @57) */ > eeprom@5f { > - compatible = "st,24c64", "atmel,24c64"; > + compatible = "atmel,24c64d-wl"; This compatible is not documented. Please add it to schema. > reg = <0x5f>; > - size = <32>; > - pagesize = <32>; > vcc-supply = <®_v3v3>; > }; > > -- > 2.34.1 >
Hi Rob, thanks for the feedback. Am Montag, 12. Februar 2024, 23:35:01 CET schrieb Rob Herring: > On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > > Now that there is a dedicated compatible for the idendification page use > > that instead. This also allows the removal the size and pagesize > > properties. > > This commit message fails to answer Why? The original DT entry using the regular "atmel,24c64" compatible is just a workaround. The size and pagesize properties are added to match that dedicated memory block. > And fails to mention the ABI break. Can you elaborate the ABI break? > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi index > > f6e422dc2663e..9d2328c185c90 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { > > > > /* protectable identification memory (part of M24C64-D @57) */ > > eeprom@5f { > > > > - compatible = "st,24c64", "atmel,24c64"; > > + compatible = "atmel,24c64d-wl"; > > This compatible is not documented. Please add it to schema. It already is. Please refer to commit 0997ff1fc1436 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page"). Thanks, Alexander > > reg = <0x5f>; > > > > - size = <32>; > > - pagesize = <32>; > > > > vcc-supply = <®_v3v3>; > > > > };
diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi index f6e422dc2663e..9d2328c185c90 100644 --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { /* protectable identification memory (part of M24C64-D @57) */ eeprom@5f { - compatible = "st,24c64", "atmel,24c64"; + compatible = "atmel,24c64d-wl"; reg = <0x5f>; - size = <32>; - pagesize = <32>; vcc-supply = <®_v3v3>; };
Now that there is a dedicated compatible for the idendification page use that instead. This also allows the removal the size and pagesize properties. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)