| Message ID | 20240116084618.3112410-3-tim@feathertop.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: rockchip: Add support for rk809 audio codec | expand |
On Tue, 16 Jan 2024 19:46:17 +1100, Tim Lunn wrote: > Fix typo in the example specifying wrong compatible string > > Signed-off-by: Tim Lunn <tim@feathertop.org> > --- > > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/rockchip,rk809.example.dtb: pmic@1b: 'vcc10-supply', 'vcc11-supply', 'vcc12-supply' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240116084618.3112410-3-tim@feathertop.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, 16 Jan 2024 19:46:17 +1100, Tim Lunn wrote: > Fix typo in the example specifying wrong compatible string > > Signed-off-by: Tim Lunn <tim@feathertop.org> > --- > > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Jan 16, 2024 at 1:37 PM Rob Herring <robh@kernel.org> wrote: > > > On Tue, 16 Jan 2024 19:46:17 +1100, Tim Lunn wrote: > > Fix typo in the example specifying wrong compatible string > > > > Signed-off-by: Tim Lunn <tim@feathertop.org> > > --- > > > > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Acked-by: Rob Herring <robh@kernel.org> Err, withdrawn. This doesn't pass tests. Rob
On 16/01/2024 09:46, Tim Lunn wrote: > Fix typo in the example specifying wrong compatible string > > Signed-off-by: Tim Lunn <tim@feathertop.org> > --- > > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > index bac2e751e2f2..3f31478932c2 100644 > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > @@ -154,8 +154,8 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - rk808: pmic@1b { > - compatible = "rockchip,rk808"; > + rk809: pmic@1b { You can just drop the label... Is it used here? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml index bac2e751e2f2..3f31478932c2 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml @@ -154,8 +154,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - rk808: pmic@1b { - compatible = "rockchip,rk808"; + rk809: pmic@1b { + compatible = "rockchip,rk809"; reg = <0x1b>; #clock-cells = <1>; clock-output-names = "xin32k", "rk808-clkout2";
Fix typo in the example specifying wrong compatible string Signed-off-by: Tim Lunn <tim@feathertop.org> --- Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)