| Message ID | 20240116132102.3272682-3-tim@feathertop.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: rockchip: Add support for rk809 audio codec | expand |
On Wed, Jan 17, 2024 at 12:21:01AM +1100, Tim Lunn wrote: > Fix typo in the example specifying wrong compatible string for rk809. > Remove additional vccX-supply properties that dont exist on rk809. > > Signed-off-by: Tim Lunn <tim@feathertop.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> A fixes tag would be nice too I suppose. Not worth resending for IMO since b4 will pick it up if you reply with one. Thanks, Conor.
On 16/01/2024 14:21, Tim Lunn wrote: > Fix typo in the example specifying wrong compatible string for rk809. > Remove additional vccX-supply properties that dont exist on rk809. > > Signed-off-by: Tim Lunn <tim@feathertop.org> > > --- > > Changes in v2: > - Fix vcc-supply warning detected by dt_binding bot > > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > index bac2e751e2f2..9b9d670708ce 100644 > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml > @@ -154,8 +154,8 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - rk808: pmic@1b { > - compatible = "rockchip,rk808"; > + rk809: pmic@1b { Drop label. Best regards, Krzysztof
On 1/17/24 04:07, Conor Dooley wrote: > On Wed, Jan 17, 2024 at 12:21:01AM +1100, Tim Lunn wrote: >> Fix typo in the example specifying wrong compatible string for rk809. >> Remove additional vccX-supply properties that dont exist on rk809. >> >> Signed-off-by: Tim Lunn <tim@feathertop.org> Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml") > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > A fixes tag would be nice too I suppose. Not worth resending for IMO > since b4 will pick it up if you reply with one. > > Thanks, > Conor.
Hi Krzysztof, On 1/17/24 18:43, Krzysztof Kozlowski wrote: > On 16/01/2024 14:21, Tim Lunn wrote: >> Fix typo in the example specifying wrong compatible string for rk809. >> Remove additional vccX-supply properties that dont exist on rk809. >> >> Signed-off-by: Tim Lunn <tim@feathertop.org> >> >> --- >> >> Changes in v2: >> - Fix vcc-supply warning detected by dt_binding bot >> >> Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> index bac2e751e2f2..9b9d670708ce 100644 >> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> @@ -154,8 +154,8 @@ examples: >> #address-cells = <1>; >> #size-cells = <0>; >> >> - rk808: pmic@1b { >> - compatible = "rockchip,rk808"; >> + rk809: pmic@1b { > Drop label. > Yep, will fix. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml index bac2e751e2f2..9b9d670708ce 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml @@ -154,8 +154,8 @@ examples: #address-cells = <1>; #size-cells = <0>; - rk808: pmic@1b { - compatible = "rockchip,rk808"; + rk809: pmic@1b { + compatible = "rockchip,rk809"; reg = <0x1b>; #clock-cells = <1>; clock-output-names = "xin32k", "rk808-clkout2"; @@ -174,9 +174,6 @@ examples: vcc7-supply = <&vcc_sysin>; vcc8-supply = <&vcc3v3_sys>; vcc9-supply = <&vcc_sysin>; - vcc10-supply = <&vcc_sysin>; - vcc11-supply = <&vcc_sysin>; - vcc12-supply = <&vcc3v3_sys>; regulators { vdd_center: DCDC_REG1 {
Fix typo in the example specifying wrong compatible string for rk809. Remove additional vccX-supply properties that dont exist on rk809. Signed-off-by: Tim Lunn <tim@feathertop.org> --- Changes in v2: - Fix vcc-supply warning detected by dt_binding bot Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)