| Message ID | 20240118112739.2000497-5-dawei.li@shingroup.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Minor cleanup on gic(v3) and genirq | expand |
On Thu, 18 Jan 2024 11:27:39 +0000, Dawei Li <dawei.li@shingroup.cn> wrote: > > For !CONFIG_SPARSE_IRQ kernel, early_irq_init() is supposed to > initialize all the desc entries in system, desc->resend_node > included. > > Thus, initialize desc->resend_node for all irq_desc entries, rather > than irq_desc[0] only, which is the current implementation is about. > > Fixes: bc06a9e08742 ("genirq: Use hlist for managing resend handlers") > Cc: stable@vger.kernel.org > > Signed-off-by: Dawei Li <dawei.li@shingroup.cn> > --- > kernel/irq/irqdesc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > index 27ca1c866f29..371eb1711d34 100644 > --- a/kernel/irq/irqdesc.c > +++ b/kernel/irq/irqdesc.c > @@ -600,7 +600,7 @@ int __init early_irq_init(void) > mutex_init(&desc[i].request_mutex); > init_waitqueue_head(&desc[i].wait_for_threads); > desc_set_defaults(i, &desc[i], node, NULL, NULL); > - irq_resend_init(desc); > + irq_resend_init(&desc[i]); > } > return arch_early_irq_init(); > } Well spotted. It would probably be worth having a helper that fully initialises one desc, but that's out of the scope of this fix. Acked-by: Marc Zyngier <maz@kernel.org> M.
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 27ca1c866f29..371eb1711d34 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -600,7 +600,7 @@ int __init early_irq_init(void) mutex_init(&desc[i].request_mutex); init_waitqueue_head(&desc[i].wait_for_threads); desc_set_defaults(i, &desc[i], node, NULL, NULL); - irq_resend_init(desc); + irq_resend_init(&desc[i]); } return arch_early_irq_init(); }
For !CONFIG_SPARSE_IRQ kernel, early_irq_init() is supposed to initialize all the desc entries in system, desc->resend_node included. Thus, initialize desc->resend_node for all irq_desc entries, rather than irq_desc[0] only, which is the current implementation is about. Fixes: bc06a9e08742 ("genirq: Use hlist for managing resend handlers") Cc: stable@vger.kernel.org Signed-off-by: Dawei Li <dawei.li@shingroup.cn> --- kernel/irq/irqdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)