From patchwork Fri Jan 19 10:45:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13523583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F388FC4725D for ; Fri, 19 Jan 2024 10:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ypmF1t81S0sYBzi4tC2MPGlsz++LptqjhmIl6a83dwE=; b=A7Egy2CF3saVYW WxH4aM9izge1NRUTQbaYOfalAC3RCUVvTOwaBr+1tegugSpj+ZG9to8/oBFJlUgR18yE54dBNMot+ WHKZruNyUYQoWhUlLG+bePY28yWXSiFnims/6d8H9gJ/ZZ9eqrYVmSj/Vm+JC0GPxAnY2bQ51Tb5e 2gES9lQ0Pihjt5utNsXpB/iffJ4a0E11J/QpC8OEQW/kVtMATKCUhs9Z2eXYT+vCdvKV7asdfJiV3 eeavV+BJdj9xjB37wXI5VmVuyn2VA3zndAl6x73lsC5+FV9c+VDsWKPc9Ow4Z9v3W2wIgWuHC/vrI lgQbNn+Pvg503ZZSEVrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQmNl-0057Vp-1j; Fri, 19 Jan 2024 10:45:53 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQmNa-0057ME-2f for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 10:45:44 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40e8fec0968so7820295e9.1 for ; Fri, 19 Jan 2024 02:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705661141; x=1706265941; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BKtqqOLjqJGdMtonI4P5mEMTKVliGwJ+zwCnWH5C8bk=; b=PjtjlkxyEVC6svvmR1p6W/W9cLE29UVwVLDH+P8sBdG6HZXnGewjmxdxK0FYFgWloh 6GY084f0/Oq4cmOgd3wPWX0vO7YkPnlaOAFambbCWs29mjYpZehXOQcHPHmKx4bLmANV ZRgRuPxEhrAJpcVy51cPZ60Sin4s/qdYvNm365aRAKYfPMYsufw3Jnqf90jSXbO0l5sb 8Y9eMwOzwW8TCAJ2PVF0MjWnqTQzJI0jaQjufW0e2T55BcxfBoyekmJsHdYt7/i7qhTa T3zwdhSHH7x+fS+N5e8Va4j9KxTH9joV+2RuiHipX7IQ5oK7W49wWEIlXWtYdoSceEFh ZtgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705661141; x=1706265941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BKtqqOLjqJGdMtonI4P5mEMTKVliGwJ+zwCnWH5C8bk=; b=tjoROxTZIvhDWArob1NZBljv9uREFIvVVLKKfKpVykSyG/OJg/5Tznl6Cux5r32Swd ISoVoZOdkG7j6DlP6dSk9eyYzhWcx/0lV4eTdD0FvNT5OeQjBTgAXWKeJlU8GQ98/YW1 2yODXmdfNJ/VbVJCAM0yH55/pYX/o2uR2mWLmITI+8Ejcsq4/xsFooB7vSBiMobKPt7y AlN7rroa855Ni772BWlZ70Lc4awFO1vuj4xp2YPRvzKWk3FC/fUPabS8FSQZP6gVSFqK PeeKS+mt/DOcrOCEAL0mqlXan0jIFCusU5Yw0+An7lNRF9ZX9IDSaBCu7YTmJXhIq4To v6iA== X-Gm-Message-State: AOJu0YzAsfaOP3fh2dIunGOLskza8sYigRAM573hDP06FOVzN2by7XBX LSUTZ1aHMXF0UJZrUf7FKowbn4zzn41SvNORIEyFYChBe/CSqz4cNLkSQUHHnKT0ChGf8YblpY8 fRJM= X-Google-Smtp-Source: AGHT+IG4Y1qsP7t7ylEa/vU+m005rweLwKBMwyulcKNBD5OybDrKdZCdyTNr5tSCDvcQkIt7aSdNiA== X-Received: by 2002:a05:600c:5116:b0:40e:86c0:1d16 with SMTP id o22-20020a05600c511600b0040e86c01d16mr1301827wms.150.1705661141695; Fri, 19 Jan 2024 02:45:41 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id fm16-20020a05600c0c1000b0040ea10178f3sm77470wmb.21.2024.01.19.02.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 02:45:40 -0800 (PST) From: Tudor Ambarus To: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, peter.griffin@linaro.org, semen.protsenko@linaro.org, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v2 13/19] tty: serial: samsung: don't compare with zero an if (bitwise expression) Date: Fri, 19 Jan 2024 10:45:20 +0000 Message-ID: <20240119104526.1221243-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240119104526.1221243-1-tudor.ambarus@linaro.org> References: <20240119104526.1221243-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_024542_865256_503F097C X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The bitwise AND with the fifo mask is used to check if the fifo is empty or not, it doesn't care about the length, thus the comparison with zero is implicit. Rely on the implicit comparison instead. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index f8a8b459a86b..333ffa3a76a3 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -988,7 +988,7 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) u32 ufcon = rd_regl(port, S3C2410_UFCON); if (ufcon & S3C2410_UFCON_FIFOMODE) { - if ((ufstat & info->tx_fifomask) != 0 || + if ((ufstat & info->tx_fifomask) || (ufstat & info->tx_fifofull)) return 0; return TIOCSER_TEMT;