| Message ID | 20240124113336.658198-6-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display support for stm32f769-disco board | expand |
Hi Dario On 1/24/24 12:33, Dario Binacchi wrote: > As reported in the section 8.3 (i. e. Board revision history) of document > UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes > related to the board revision addressed by the patch: > - Board MB1166 revision A-09: > - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK > > The patch adds the DTS support for the new display which belongs to the > the Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > I still have the following yaml error: arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml# It seems that "port" property is missing in "novatek,nt35510.yaml" file, can you update it ? Or delete it in the dts file if not needed. With this change I'll take your series. I also saw that stm32f769-disco has a similar problem with orisetech,otm8009a.yaml file, "backlight" property is not defined. thanks in advance Alex > --- > > Changes in v9: > - Change commit message > - Rename stm32f769-disco-mb1225-revb03-mb1166-reva09 to > stm32f769-disco-mb1166-reva09 > > Changes in v8: > - Add Reviewed-by tag of Linus Walleij > - Add Reviewed-by tag of Raphael Gallais-Pou > > Changes in v7: > - Replace .dts with .dtb in the Makefile > > Changes in v6: > - Drop patches > - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK > - [7/8] drm/panel: nt35510: move hardwired parameters to configuration > - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK > because applied by the maintainer Linus Walleij > > Changes in v5: > - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional(). > > Changes in v2: > - Change the status of panel_backlight node to "disabled" > - Delete backlight property from panel0 node. > - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK" > in the same style as the original driver. > > arch/arm/boot/dts/st/Makefile | 1 + > .../dts/st/stm32f769-disco-mb1166-reva09.dts | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts > > diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile > index 7892ad69b441..9fedd6776208 100644 > --- a/arch/arm/boot/dts/st/Makefile > +++ b/arch/arm/boot/dts/st/Makefile > @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \ > stm32f469-disco.dtb \ > stm32f746-disco.dtb \ > stm32f769-disco.dtb \ > + stm32f769-disco-mb1166-reva09.dtb \ > stm32429i-eval.dtb \ > stm32746g-eval.dtb \ > stm32h743i-eval.dtb \ > diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts > new file mode 100644 > index 000000000000..014cac192375 > --- /dev/null > +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com> > + */ > + > +#include "stm32f769-disco.dts" > + > +&panel_backlight { > + status = "disabled"; > +}; > + > +&panel0 { > + compatible = "frida,frd400b25025", "novatek,nt35510"; > + vddi-supply = <&vcc_3v3>; > + vdd-supply = <&vcc_3v3>; > + /delete-property/backlight; > + /delete-property/power-supply; > +};
diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile index 7892ad69b441..9fedd6776208 100644 --- a/arch/arm/boot/dts/st/Makefile +++ b/arch/arm/boot/dts/st/Makefile @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \ stm32f469-disco.dtb \ stm32f746-disco.dtb \ stm32f769-disco.dtb \ + stm32f769-disco-mb1166-reva09.dtb \ stm32429i-eval.dtb \ stm32746g-eval.dtb \ stm32h743i-eval.dtb \ diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts new file mode 100644 index 000000000000..014cac192375 --- /dev/null +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1166-reva09.dts @@ -0,0 +1,18 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com> + */ + +#include "stm32f769-disco.dts" + +&panel_backlight { + status = "disabled"; +}; + +&panel0 { + compatible = "frida,frd400b25025", "novatek,nt35510"; + vddi-supply = <&vcc_3v3>; + vdd-supply = <&vcc_3v3>; + /delete-property/backlight; + /delete-property/power-supply; +};