diff mbox series

[1/2] dt-bindings: arm: fsl: remove redundant company name

Message ID 20240124154422.3600920-2-hugo@hugovil.com (mailing list archive)
State New, archived
Headers show
Series board: imx8mn-rve-gateway: fix compatible description | expand

Commit Message

Hugo Villeneuve Jan. 24, 2024, 3:44 p.m. UTC 
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Company name in compatible description appears twice, which is not really
helpful, so remove it from product name.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Conor Dooley Jan. 24, 2024, 4 p.m. UTC | #1 
On Wed, Jan 24, 2024 at 10:44:20AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Company name in compatible description appears twice, which is not really
> helpful, so remove it from product name.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

This only landed in 6.8-rc1, right?
With a Fixes: tag this would probably be okay, but this does seem on the
"not worth fixing" side of things to be honest.

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 228dcc5c7d6f..f455c0172c84 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1026,7 +1026,7 @@ properties:
>          items:
>            - enum:
>                - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
> -              - rve,rve-gateway # i.MX8MN RVE Gateway Board
> +              - rve,gateway # i.MX8MN RVE Gateway Board
>                - variscite,var-som-mx8mn-symphony
>            - const: variscite,var-som-mx8mn
>            - const: fsl,imx8mn
> -- 
> 2.39.2
>
Hugo Villeneuve Jan. 24, 2024, 4:26 p.m. UTC | #2 
On Wed, 24 Jan 2024 16:00:48 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Jan 24, 2024 at 10:44:20AM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Company name in compatible description appears twice, which is not really
> > helpful, so remove it from product name.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> This only landed in 6.8-rc1, right?

Hi,
yes.

> With a Fixes: tag this would probably be okay, but this does seem on the
> "not worth fixing" side of things to be honest.

I will add a "Fixes:" tag then, because for me it is worth fixing.

Hugo Villeneuve
 

> 
> Cheers,
> Conor.
> 
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 228dcc5c7d6f..f455c0172c84 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1026,7 +1026,7 @@ properties:
> >          items:
> >            - enum:
> >                - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
> > -              - rve,rve-gateway # i.MX8MN RVE Gateway Board
> > +              - rve,gateway # i.MX8MN RVE Gateway Board
> >                - variscite,var-som-mx8mn-symphony
> >            - const: variscite,var-som-mx8mn
> >            - const: fsl,imx8mn
> > -- 
> > 2.39.2
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 228dcc5c7d6f..f455c0172c84 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1026,7 +1026,7 @@  properties:
         items:
           - enum:
               - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
-              - rve,rve-gateway # i.MX8MN RVE Gateway Board
+              - rve,gateway # i.MX8MN RVE Gateway Board
               - variscite,var-som-mx8mn-symphony
           - const: variscite,var-som-mx8mn
           - const: fsl,imx8mn