| Message ID | 20240124164646.1506814-2-hugo@hugovil.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | board: imx8mn-rve-gateway: fix compatible description | expand |
On 24/01/2024 17:46, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Company name in compatible description appears twice, which is not really > helpful, so remove it from product name. It's just a string. There is no bug, at least you did not describe where the bug is. This has probably little impact on user-space, but there could be such which actually reads compatibles and depends on them. Or bootloader or whatever. Therefore to me such cosmetic change of correct compatible is not worth ABI impact. Best regards, Krzysztof
On Wed, 24 Jan 2024 18:00:00 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 24/01/2024 17:46, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Company name in compatible description appears twice, which is not really > > helpful, so remove it from product name. > > It's just a string. There is no bug, at least you did not describe where > the bug is. Hi Krzysztof, in fact the fix is based on comments you made in a review for another board that I submitted: https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/ ------------------ Company name appears twice, which is not really helpful. What's the true name? Gateway EVK? Then keep only this. ----------------- > This has probably little impact on user-space, but there could be such > which actually reads compatibles and depends on them. Or bootloader or > whatever. Therefore to me such cosmetic change of correct compatible is > not worth ABI impact. Yes, normally you would be right, but in this specific case, the board is a prototype developped by my company and we are still at the prototype stage, so there is zero ABI impact. Maybe I can add this to the cover letter if you want me to submit a V3. Hugo Villeneuve
On 24/01/2024 18:08, Hugo Villeneuve wrote: > On Wed, 24 Jan 2024 18:00:00 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 24/01/2024 17:46, Hugo Villeneuve wrote: >>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com> >>> >>> Company name in compatible description appears twice, which is not really >>> helpful, so remove it from product name. >> >> It's just a string. There is no bug, at least you did not describe where >> the bug is. > > Hi Krzysztof, > in fact the fix is based on comments you made in a > review for another board that I submitted: > > https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/ > > ------------------ > Company name appears twice, which is not really helpful. What's the true > name? Gateway EVK? Then keep only this. You are mixing arguments. You want to change released compatible based on style comment. Style comments are reasonable comments for compatibles while they are patches. Not released commits. > ----------------- > >> This has probably little impact on user-space, but there could be such >> which actually reads compatibles and depends on them. Or bootloader or >> whatever. Therefore to me such cosmetic change of correct compatible is >> not worth ABI impact. > > Yes, normally you would be right, but in this specific case, the board > is a prototype developped by my company and we are still at the > prototype stage, so there is zero ABI impact. > > Maybe I can add this to the cover letter if you want me to submit a V3. Any explanation and possible ABI impact should be in commit msg. Anyway, one patchset per day, so people have chance to respond... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 228dcc5c7d6f..f455c0172c84 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1026,7 +1026,7 @@ properties: items: - enum: - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board - - rve,rve-gateway # i.MX8MN RVE Gateway Board + - rve,gateway # i.MX8MN RVE Gateway Board - variscite,var-som-mx8mn-symphony - const: variscite,var-som-mx8mn - const: fsl,imx8mn