| Message ID | 20240125145007.748295-2-tudor.ambarus@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: s3c64xx: winter cleanup and gs101 support | expand |
On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > The driver uses readl() but does not include <linux/io.h>. > > It is good practice to directly include all headers used, it avoids > implicit dependencies and spurious breakage if someone rearranges > headers and causes the implicit include to vanish. > > Include the missing header. > > Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") Not sure the "Fixes" tag is needed here. AFAIU, this patch doesn't fix any actual bugs, seems more like a style fix to me. In other words, I'm not convinced it has to be necessarily backported to stable kernels. The same goes for another similar patch from this series. > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/spi/spi-s3c64xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 7f7eb8f742e4..c1cbc4780a3b 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -10,6 +10,7 @@ > #include <linux/clk.h> > #include <linux/dma-mapping.h> > #include <linux/dmaengine.h> > +#include <linux/io.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/spi/spi.h> > -- > 2.43.0.429.g432eaa2c6b-goog >
On 1/25/24 18:58, Sam Protsenko wrote: > On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: >> >> The driver uses readl() but does not include <linux/io.h>. >> >> It is good practice to directly include all headers used, it avoids >> implicit dependencies and spurious breakage if someone rearranges >> headers and causes the implicit include to vanish. >> >> Include the missing header. >> >> Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") > > Not sure the "Fixes" tag is needed here. AFAIU, this patch doesn't fix fixes tag indicates which commit failed to include the necessary header > any actual bugs, seems more like a style fix to me. In other words, not yet, but we can't estimate what header get rearranged and whether it will cause the implicit include to vanish. > I'm not convinced it has to be necessarily backported to stable > kernels. The same goes for another similar patch from this series. It would be good to have this in the stable kernels for the reasons described in the commit message. > >> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> >> --- >> drivers/spi/spi-s3c64xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 7f7eb8f742e4..c1cbc4780a3b 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -10,6 +10,7 @@ >> #include <linux/clk.h> >> #include <linux/dma-mapping.h> >> #include <linux/dmaengine.h> >> +#include <linux/io.h> >> #include <linux/platform_device.h> >> #include <linux/pm_runtime.h> >> #include <linux/spi/spi.h> >> -- >> 2.43.0.429.g432eaa2c6b-goog >>
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7f7eb8f742e4..c1cbc4780a3b 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -10,6 +10,7 @@ #include <linux/clk.h> #include <linux/dma-mapping.h> #include <linux/dmaengine.h> +#include <linux/io.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spi/spi.h>
The driver uses readl() but does not include <linux/io.h>. It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)