From patchwork Thu Jan 25 20:36:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13531690 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8B04C47258 for ; Thu, 25 Jan 2024 20:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4joPP2uSv45KBwdhsQi8FJPx5MfYyo8tQSxGkmPlQfg=; b=nqadhxr0VmjBdX 7kl0HTZihxwW+BrKp3zY1UOCygxqCn4EaL1g15oO6eu77KwDZJ5RuJGFsCGtJswkyS16InCok8IQz Dx6YVE6KGPBS6PelvX+e8kt/ENiJHQid1IHeXYpkFdpAgAj+hpl1BVINOj3l5BeZSG9zLArX/vd7k NQiodULdwNAClImOY2Nz0R7zy7AfJsQNhGkIziIg+XPNSjF8HIGIh0p1Thi+9HJVW0lDXMeGIAQUC DLOb5BWWefzw5vAgZeWjVSD0eJTBrBPqpXQkLgmLOUGXXEjJCM4fwPGUQiJrwA3/K4+b5dIhi47uC mjmHjLOkO0FifcU/xurA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT6Td-00000001oGp-2oxp; Thu, 25 Jan 2024 20:37:33 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT6TS-00000001oBs-3wLb for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 20:37:24 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40ed28f8666so9577145e9.3 for ; Thu, 25 Jan 2024 12:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706215040; x=1706819840; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5TK/jzjeKhCUMdn84sRlAxs0YdsDSfP3y0ZAKcUDPB0=; b=EXxhERbdk50eUztTu+mcHV6awD+Nkqxpy3AKRvRK6P6RB+x1YEQ02TZLSbFUrkAkLF r1SJV80cR1z8+nNNxStiFmQcwrlBT7RLocO0wK9Ov8s22EY8xduATv6oUSLmDre3HQ6m vf5LFCeJfCTcW3wYX38qpB/mNR7YaXxrNRmsBlc3sEmfvnRwCDowGx4D3dswWbjGi63o mU+oRV3mToF9ocdVCKiC1qknZMNBWIxXKMohlLCfQtQv0qL7Si0GVERKIACOzcRPKcpW CkvtHTywbCss28nNh8Uoe3zGm6IO55tgY/3CvBxdIekl/VRWegEgDrHhIvOqgSSBV0G0 VeSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706215040; x=1706819840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5TK/jzjeKhCUMdn84sRlAxs0YdsDSfP3y0ZAKcUDPB0=; b=UJ/h/KByxqHWqrojNETdj9MGp/aL9g8y+CBEVHcgwIV0yqzwG9f8eE7j9vlDEZaGD6 3CZuRrn6hmjF5Xd+KNmd7w4p1wy2BHq5L+WEH3KKkYrUpeFcWYV34fibaw2gTLnpLCUZ 5az5lm45EKiEAARZEzN4Ocdhoi+ft7ZGEUVsxwbnOPRQISM9t2EfzeDaIQtUw4thhrNz DrpC5ImTGx8BMb9JiRbh6Ppt5VfzfGUHQMj89Vs1pe9uiz3worw4eurKLMzEpn4H0Ccv nbLk/ZvNMohdLK2RlbmiIsouPQVDBJbuvQH1SAvn1bqlRxL7LAQ6DjWqkjwgg6eEJd9F ZJHw== X-Gm-Message-State: AOJu0Yz2VHLO07se6naRUFUxI+nK/2iB5rdnCaXPY7VjO6A7oWnrP43p EBekFsGKtgMd6LEQYGmUgti0G5fP+7h71lRWAQYV9K9oR6/NmSqx X-Google-Smtp-Source: AGHT+IGCiq220SzI05Ov5whoR+Ji/qT4+tozqCDUBnT1AN0iy5c4d6zxzxeF9zpwxBfvVyYUXrlBnQ== X-Received: by 2002:a1c:740b:0:b0:40e:7081:4d78 with SMTP id p11-20020a1c740b000000b0040e70814d78mr178532wmc.140.1706215039905; Thu, 25 Jan 2024 12:37:19 -0800 (PST) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id j32-20020a05600c1c2000b0040e813f1f31sm3817700wms.25.2024.01.25.12.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 12:37:19 -0800 (PST) From: Christian Marangi To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?b?UmFmYcWCIE1p?= =?utf-8?b?xYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , Jacek Anaszewski , =?utf-8?q?Fern=C3=A1ndez_Roj?= =?utf-8?q?as?= , Sven Schwermer , Christian Marangi , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: Rob Herring Subject: [net-next PATCH v10 1/5] dt-bindings: net: phy: Make LED active-low property common Date: Thu, 25 Jan 2024 21:36:57 +0100 Message-ID: <20240125203702.4552-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240125203702.4552-1-ansuelsmth@gmail.com> References: <20240125203702.4552-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_123723_033279_2E567BF3 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move LED active-low property to common.yaml. This property is currently defined multiple times by bcm LEDs. This property will now be supported in a generic way for PHY LEDs with the use of a generic function. With active-low bool property not defined, active-high is always assumed. Signed-off-by: Christian Marangi Reviewed-by: Andrew Lunn Acked-by: Lee Jones Reviewed-by: Rob Herring --- Changes v10: - Add Review and Ack tag Changes v5: - Make active-low generic Changes v4: - Drop support for global active-low - Rework to polarity option (for marvell10g series support) Changes v3: - Out of RFC Changes v2: - Add this patch Documentation/devicetree/bindings/leds/common.yaml | 6 ++++++ Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 4 ---- Documentation/devicetree/bindings/leds/leds-bcm6328.yaml | 4 ---- Documentation/devicetree/bindings/leds/leds-bcm6358.txt | 2 -- .../devicetree/bindings/leds/leds-pwm-multicolor.yaml | 4 ---- Documentation/devicetree/bindings/leds/leds-pwm.yaml | 5 ----- 6 files changed, 6 insertions(+), 19 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 55a8d1385e21..5633e0aa6bdf 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -200,6 +200,12 @@ properties: #trigger-source-cells property in the source node. $ref: /schemas/types.yaml#/definitions/phandle-array + active-low: + type: boolean + description: + Makes LED active low. To turn the LED ON, line needs to be + set to low voltage instead of high. + # Required properties for flash LED child nodes: flash-max-microamp: description: diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml index 52252fb6bb32..bb20394fca5c 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml +++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml @@ -52,10 +52,6 @@ patternProperties: maxItems: 1 description: LED pin number - active-low: - type: boolean - description: Makes LED active low - required: - reg diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml b/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml index 51cc0d82c12e..f3a3ef992929 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml +++ b/Documentation/devicetree/bindings/leds/leds-bcm6328.yaml @@ -78,10 +78,6 @@ patternProperties: - maximum: 23 description: LED pin number (only LEDs 0 to 23 are valid). - active-low: - type: boolean - description: Makes LED active low. - brcm,hardware-controlled: type: boolean description: Makes this LED hardware controlled. diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt index 6e51c6b91ee5..211ffc3c4a20 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt +++ b/Documentation/devicetree/bindings/leds/leds-bcm6358.txt @@ -25,8 +25,6 @@ LED sub-node required properties: LED sub-node optional properties: - label : see Documentation/devicetree/bindings/leds/common.txt - - active-low : Boolean, makes LED active low. - Default : false - default-state : see Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : see diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml index bd6ec04a8727..5edfbe347341 100644 --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml @@ -41,10 +41,6 @@ properties: pwm-names: true - active-low: - description: For PWMs where the LED is wired to supply rather than ground. - type: boolean - color: true required: diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml index 7de6da58be3c..113b7c218303 100644 --- a/Documentation/devicetree/bindings/leds/leds-pwm.yaml +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml @@ -34,11 +34,6 @@ patternProperties: Maximum brightness possible for the LED $ref: /schemas/types.yaml#/definitions/uint32 - active-low: - description: - For PWMs where the LED is wired to supply rather than ground. - type: boolean - required: - pwms - max-brightness