From patchwork Fri Jan 26 17:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13532911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A7BC48285 for ; Fri, 26 Jan 2024 17:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n7NeFOCbyZTyxsoc6urA0Rsw9yNyDUFAske1t0Yq4Bc=; b=HdXRiBYAeKjZJR GHkrq2QBC4NI+WWUXHMZjb3tNaWUrvl37g1mjdo12DvXmDcE95COo7ZqM1e69OYNQsdYWeTkCG8wz BiR5BtN41ZdFjo/sytmjfw6WVfO52RkyP0Szw08QOG/cHuhboOiF7nOt13H2zqK95K0UYTa7bAMpZ 3V9OB7ltTw+89Y0yEiLtg7zCSiBpZxcCerz4IqAQXlmLamz4W8so4QdDMnAOpftxyegbA4wuEOolM kr3bEdKS1xndKj+yClGTnyH92BJZwvoYzJeSEUpRaOe40J5UQMyIBBZ+Kx2HfUvwVvVtJA9oa1SX6 QS+soStMzeyhPiCRdC7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPpb-00000004qQy-48NV; Fri, 26 Jan 2024 17:17:31 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPoD-00000004pUm-3LyU for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 17:16:08 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40ea5653f6bso11005325e9.3 for ; Fri, 26 Jan 2024 09:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706289361; x=1706894161; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OFdCZ+E7BFUbmZ2dzvoSTWD6D1fnBZ2RDi/MQ7bu2EU=; b=NZLCf2QL7YdG279bRC11d0ciwGs6HxdPLwYKYWGE4HRXtxWBIleIyydstbE1cxD1MN 8z5m7lM4MWnZ3gs8/vL49L9QT9VVw2VOKcdkArCPWz/tft8FjOh6YGRSZOU0yyFOZ/SO cPHRrdski/QBNQcmVnH7k9yK+oZ3NvgJiCni2v8YC+ej8OyASsFtb31O+wup6VQ8mqtq f81AZFgdtxL7MISJa2oYlghAWqQQTcMtTvIc6MFvGxNoj+aoVT7c5FXCaz1cFq5CFqbp /ES7RjPcsSMyyeGp+qf5ySR2R+JDOORXxIueJPANbgU2RJvqP/iHQfyR7yeSNBPnweM5 ivzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706289361; x=1706894161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFdCZ+E7BFUbmZ2dzvoSTWD6D1fnBZ2RDi/MQ7bu2EU=; b=n+xkGhgAwR7zU4kej7C2rXnVxM79zbiM0LDxbwfr3pXNcKPHu3GA4XyrytuML+Lgh5 8FEckV8MYvIbZNlFvGOu45STxjr6unRWoEk7eapvcwxdfzSUZxRSsE7C0NcxzdPNT/ti MUiV8vdGF797l9Jd5xZTcJjYqRhgXXZ7ng7KJmYhYmPmVc09exTby1oJDT8WNh5HpKuB xQiOCm4VWpSlF8qtUqpooH77xrEOTX/pHwmcqfFeCvp0B4Aidm+Si/mYMotbmhujrFe8 PC2R8oyZWQ4HKX3SKXDRYvpRJOGCFH3hYvJp7T0EnqlZlia0iqkHXfLUfUJ57Pw2T0/F 5j6A== X-Gm-Message-State: AOJu0Yz0g/xY/IvkHWvKfiL+zr0WubAamcwYElYjod/otRILeh2l0Glq XANPkKt/7GMTzX4F7ruOhn6yOMYV93eBZvtHswV8EDgw44zYbG5YiSplDOsCesI= X-Google-Smtp-Source: AGHT+IHAdoE7ZY9wf1qj3d+JD3BcLNSbHlFCODLChuw3+wfJAwKowp+5DxpzG8f1Cx3S5gdIKHCLrQ== X-Received: by 2002:a05:600c:3ca7:b0:40e:62b1:58a5 with SMTP id bg39-20020a05600c3ca700b0040e62b158a5mr90288wmb.15.1706289361429; Fri, 26 Jan 2024 09:16:01 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id k10-20020a05600c1c8a00b0040e451fd602sm6287286wms.33.2024.01.26.09.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:16:00 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, jassi.brar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v3 10/17] spi: s3c64xx: propagate the dma_submit_error() error code Date: Fri, 26 Jan 2024 17:15:38 +0000 Message-ID: <20240126171546.1233172-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240126171546.1233172-1-tudor.ambarus@linaro.org> References: <20240126171546.1233172-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_091605_908749_2B09CEDA X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 6268790bbcff..64daf944b245 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -321,7 +321,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch);