From patchwork Sat Jan 27 00:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0FA3C47422 for ; Sat, 27 Jan 2024 00:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jV4S/d5XmryuPj6qtVxoCKez3p6mMVdcI+3jF6E6fNo=; b=jV4B4aMh4c/oyk wCHl4AAzqCfO4xvXdLjqIFOP566GPoUkkAth+LSCI+F3M6Pj5XOUhl0c+hU4QqT/yUEQY8XMxJkfJ ftoVE17PpvCmpNlhObjBC2WvuBOf2Zk3x810CHl4LdDWYNpIqRZct9rhFqR3D85BkqdF9d/6TAEpp 3nk1fjy1Nk3A6XXV45OeZoM06DpZMRN2x1EgM2+0N1vSI1/y+w91us3lDlj8dC9V52x+SKxIjL5gb zgAg82pFuHRJvIlFiCGZN2Fr7jstoYmMIa76ddaW/0ZLMj4anTORUcU0MrGQNvQBK1PKug66ds8X3 RI3mYGqslg8D0EUxkD+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWhC-00000005zF7-0gFK; Sat, 27 Jan 2024 00:37:18 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh3-00000005zBK-07O7 for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:10 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40ed3101ce3so20034045e9.2 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=u57OosoQ0tja+LACoTuc4Fz1jYcPehLlfh4OY1B+PrhqKglei8Vrh0klitBm8gkUnG tkOVfzogLv3CA0JIN87O7+/hWW4YHn8k7eMjEnxtuMe5HgI4l1KWO0gaXgthUWPfJvKa 6tHtGuSPrdWqCUynJO0yenM26ZnfB0pbZeGdDP7PNTqi3SBwAxkhOgJr9syFe+71JSSQ 0jk98WPBMnCzLs3P48mVOk1dZKGQ7tcEvTp7EuD6vqi+Lu89ad0nmKUYXp0t8JlnKdTn TLDr7aZbVE2rz/l7c2uTlPpXRXdNZprouQ5RgH6k7rNfT+GHAdCRg2W7xExPMeygpvKi kc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=WFjn8eM6zAwydwQpcg8mi7kujtrUPoiLrQRwoPenJmpF3uiazJzcRvLHwMSbbUnjOB dOGIF8NNypHKB1fsKcmD1Lg3EIelCp5JTYUwDkFXUfKtNY3GhFsQT7otSQIuhK1I4fBC 4HH6ZIoRObtJdbihQdR8veNqgpM/mgOF4r6+64IhFKHGQBaGP63eWtwNqV7BwGEcTdPn fNnHBldM2hZDyFzoRkzxVV0kKNy2EaqCIBaowmzf0x9ED8MLUV6tjeS5/JT4EcmjpRJs fdPyew2x4yV0Y4RwpRMvRud5sINRpekyOltAzZBJUP7XCfO/RfVc+ySasRjYDGb0fHd1 AbKw== X-Gm-Message-State: AOJu0Yw7yHXnEFkn61mbfHFwROKQ9GJJrLBqH6gHuhXMOixSiU5hshrp XjpgHk+R+5WkJONuHpEoqCspquBHVYP6bIuhcGdTTGsihC3kEkSYNYMUFf0J6UU= X-Google-Smtp-Source: AGHT+IGorEDbWQE6VfxFvlvSCPqIp6nl1sPSWqI+VAkqF7VgEu3yF8ZBjC3O57a4HzCVQzahFOXsXA== X-Received: by 2002:a05:6000:1370:b0:337:bb78:8b3e with SMTP id q16-20020a056000137000b00337bb788b3emr210753wrz.197.1706315826560; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:06 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart Date: Sat, 27 Jan 2024 00:35:53 +0000 Message-ID: <20240127003607.501086-5-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163709_167859_AA49C2C6 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi8 instance here. For USI and UART, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI0_UART_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and uart drivers. Update the DTSI accordingly. Fixes: d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index e5b665be2d62..f93e937d2726 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -410,7 +410,7 @@ usi_uart: usi@10a000c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x1020>; @@ -422,7 +422,7 @@ serial_0: serial@10a00000 { reg = <0x10a00000 0xc0>; interrupts = ; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "uart", "clk_uart_baud0"; samsung,uart-fifosize = <256>;