| Message ID | 20240127161753.114685-5-apatel@ventanamicro.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Linux RISC-V AIA Support | expand |
On Sat, 27 Jan 2024 16:17:32 +0000, Anup Patel <apatel@ventanamicro.com> wrote: > > From: Thomas Gleixner <tglx@linutronix.de> > > Add a new domain bus token to prepare for device MSI which aims to replace > the existing platform MSI maze. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Anup Patel <apatel@ventanamicro.com> > --- > include/linux/irqdomain_defs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_defs.h > index c29921fd8cd1..4c69151cb9d2 100644 > --- a/include/linux/irqdomain_defs.h > +++ b/include/linux/irqdomain_defs.h > @@ -26,6 +26,7 @@ enum irq_domain_bus_token { > DOMAIN_BUS_DMAR, > DOMAIN_BUS_AMDVI, > DOMAIN_BUS_PCI_DEVICE_IMS, > + DOMAIN_BUS_DEVICE_IMS, Only a personal taste, but since we keep calling it "device MSI", which it really is, I find it slightly odd to name the token "DEVICE_IMS". From what I understand, IMS is PCIe specific. Platform (and by extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI would make a lot more sense and avoid confusion. But hey, I don't have much skin in this game, and I can probably mentally rotate the acronym... M.
On Thu, Feb 15 2024 at 11:54, Marc Zyngier wrote: > On Sat, 27 Jan 2024 16:17:32 +0000, > Anup Patel <apatel@ventanamicro.com> wrote: >> DOMAIN_BUS_PCI_DEVICE_IMS, >> + DOMAIN_BUS_DEVICE_IMS, > > Only a personal taste, but since we keep calling it "device MSI", > which it really is, I find it slightly odd to name the token > "DEVICE_IMS". > > From what I understand, IMS is PCIe specific. Platform (and by > extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI > would make a lot more sense and avoid confusion. That's true, but I chose it intentionally because Interrupt Message Store (IMS) is a (PCI) device specific way to store the message contrary to PCI/MSI[-X] which has standardized storage. So my thought was that this exactly reflects what the platform device requires: device specific message store, aka DMS or DSMS :) > But hey, I don't have much skin in this game, and I can probably > mentally rotate the acronym... I have no strong opinion about it though. Thanks, tglx
diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_defs.h index c29921fd8cd1..4c69151cb9d2 100644 --- a/include/linux/irqdomain_defs.h +++ b/include/linux/irqdomain_defs.h @@ -26,6 +26,7 @@ enum irq_domain_bus_token { DOMAIN_BUS_DMAR, DOMAIN_BUS_AMDVI, DOMAIN_BUS_PCI_DEVICE_IMS, + DOMAIN_BUS_DEVICE_IMS, }; #endif /* _LINUX_IRQDOMAIN_DEFS_H */