| Message ID | 20240127163247.384439-5-wens@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: sun50i-h616: Add DMA and SPDIF controllers | expand |
On Sun, Jan 28, 2024 at 12:32:44AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The DMA controllers found on the H616 and H618 are the same as the one > found on the A100. The only difference is the DMA endpoint (DRQ) layout. > > Since the number of channels and endpoints are described with additional > generic properties, just add a new H616-specific compatible string and > fallback to the A100 one. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > --- > Changes since v1: > - Switch to "contains" for if-properties statement > - Fall back to A100 instead of H6 > > .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > index ec2d7a789ffe..0f2501f72cca 100644 > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: allwinner,sun8i-r40-dma > - const: allwinner,sun50i-a64-dma > + - items: > + - const: allwinner,sun50i-h616-dma > + - const: allwinner,sun50i-a100-dma > > reg: > maxItems: 1 > @@ -59,10 +62,11 @@ required: > if: > properties: > compatible: > - enum: > - - allwinner,sun20i-d1-dma > - - allwinner,sun50i-a100-dma > - - allwinner,sun50i-h6-dma > + contains: > + enum: > + - allwinner,sun20i-d1-dma > + - allwinner,sun50i-a100-dma > + - allwinner,sun50i-h6-dma > > then: > properties: > -- > 2.39.2 >
On Sun, 28 Jan 2024 00:32:44 +0800 Chen-Yu Tsai <wens@kernel.org> wrote: Hi, > From: Chen-Yu Tsai <wens@csie.org> > > The DMA controllers found on the H616 and H618 are the same as the one > found on the A100. The only difference is the DMA endpoint (DRQ) layout. > > Since the number of channels and endpoints are described with additional > generic properties, just add a new H616-specific compatible string and > fallback to the A100 one. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Looks good, A100 is the right fallback string. dt-binding_check passed for me. Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > Changes since v1: > - Switch to "contains" for if-properties statement > - Fall back to A100 instead of H6 > > .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > index ec2d7a789ffe..0f2501f72cca 100644 > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: allwinner,sun8i-r40-dma > - const: allwinner,sun50i-a64-dma > + - items: > + - const: allwinner,sun50i-h616-dma > + - const: allwinner,sun50i-a100-dma > > reg: > maxItems: 1 > @@ -59,10 +62,11 @@ required: > if: > properties: > compatible: > - enum: > - - allwinner,sun20i-d1-dma > - - allwinner,sun50i-a100-dma > - - allwinner,sun50i-h6-dma > + contains: > + enum: > + - allwinner,sun20i-d1-dma > + - allwinner,sun50i-a100-dma > + - allwinner,sun50i-h6-dma > > then: > properties:
diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index ec2d7a789ffe..0f2501f72cca 100644 --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml @@ -28,6 +28,9 @@ properties: - items: - const: allwinner,sun8i-r40-dma - const: allwinner,sun50i-a64-dma + - items: + - const: allwinner,sun50i-h616-dma + - const: allwinner,sun50i-a100-dma reg: maxItems: 1 @@ -59,10 +62,11 @@ required: if: properties: compatible: - enum: - - allwinner,sun20i-d1-dma - - allwinner,sun50i-a100-dma - - allwinner,sun50i-h6-dma + contains: + enum: + - allwinner,sun20i-d1-dma + - allwinner,sun50i-a100-dma + - allwinner,sun50i-h6-dma then: properties: