From patchwork Sun Jan 28 20:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 13534651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90847C47DDB for ; Sun, 28 Jan 2024 20:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ch325g5yzwURb8ypBx+Qn1NUW10FbPw1cRQTf70OUOk=; b=Aqjladbh6msxtX 6AkolLlq/gn3O4gXfuxnQJI2DAr5ERhd+bKKRFHqgM0IaapdWqptCXlIyb4YLL4dmQyBtlXgFyf1U Xvtfm3ubLExiezBSXkkpkbIGgtXiEPlTx7K1ajMGyptWxFxfYufGNJLf458xi2Awwsj2lmNMk9e3W 52EliHXgeARMMHMd8hsWlqEgfyZ3s1QwN++p+K2e+h0W4ZoxLRMrLtMRLChcDopdZl4dfHAo1IGWX g+sbdrHmYlNDJKnlvDTwAXayFjLmr5QlLcR5QctWOXBoaehe2dNPJTOIk2QUcB3ES6nq9vPPd+uL8 M+WVHZ2+2S0AIYIFboSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUC5P-0000000AV1T-2KW8; Sun, 28 Jan 2024 20:49:03 +0000 Received: from a.peacevolution.org ([206.189.193.133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUC5C-0000000AUyK-1bN4 for linux-arm-kernel@lists.infradead.org; Sun, 28 Jan 2024 20:48:51 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id F2CFE46366; Sun, 28 Jan 2024 20:48:48 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Sun, 28 Jan 2024 15:45:10 -0500 Message-ID: <20240128204740.2355092-4-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474929; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; b=LCKLWsPlqvRQtiFZG1vk9RGo0PpHdusVxfhM+KBizv3IAzHDsEBOKiiqeQm2cRJysOQFlj yPD70phfaq/ONb8DwmyRcEqXprMWwQOEdEHKTscwSMPBAhH8XM4LwjOs+hHD/8GPzG1smq Sh/bcnY8qMKjVHRvgiSCewPgy+j4XG4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240128_124850_538191_43B0A3B2 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful and/or just causing churn. arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 6eab61a12cd8..4f39cfeb13ec 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -40,21 +40,21 @@ leds { compatible = "gpio-leds"; led0: led-0 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; led1: led-1 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; led2: led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended; @@ -64,7 +64,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = ; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };