From patchwork Tue Jan 30 09:36:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BE27C48285 for ; Tue, 30 Jan 2024 09:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ZQpmE760BQkd+VAhnHSEDWwTdKGD1m6UjZiNnSnkRo=; b=0Kt7wK0R2bfEyW KwIrFjEfwNucCUiu/ZJ7npiEFIC9l4ScfFfb+6S1WN3mN2wAPTUg/i0jRVBOWqJcLVSsiUzgLehGA uLJlGe9NSr/yU2EsMnT2MN62aldUJNrTPuKYMHnh61CKEzMx7CZOSstjHm8wg9fdqrdhMxe88ApOZ OOp/BqzJiGbB1dUCQILafreJCG1+qAcEW7j0qrpOH7IHxtYLPhzC51C6EmW0QymTVkjzopkmcLsm0 Y+Ozfo+KsJOuhXVgU8rXDX6BGYbZuagfQhEM4zKAkbDRxxCGbIkh3tZbLK1dXaEj2ZXjahRMBcv+P xr2FUTSjvgs16C/pjuGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZn-0000000FyLk-2Pky; Tue, 30 Jan 2024 09:38:43 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZa-0000000FyD6-0Utm for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:31 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-55eed368b0bso3880568a12.0 for ; Tue, 30 Jan 2024 01:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607508; x=1707212308; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RQzBQ4TASuzmiR4SqIUWePUdwbCtW+Gyj+OrWEuWMsY=; b=RiLxmfejm75St/h6RVVHJW29zzxxXzwb37fvNBD1FKHdptMQ5xxuqTNM59s7ucR5hD DsFvbeofaiZJuSwbTNLkBAAurL51bmFFDrS+uAKcQEeHS74kUjP+ztpIVJJ+M2jJEHdR coBcYiVeWBtENztBnKn7TgF1tE2qs/6MsKjbgjg0RsywhtnBiD1oQ3x/o8s+kXT1Qpl3 3lEZuXnJVK2e1U3Q5RdZfr8OQ3SIuAuvFn64CaE1gnW9s40O0lUEjr3TADH8cnMUDJZe T5jU3K/tYH32ZpU3xI+QBQbLeS7wAMSaz7q2jp4j45xuuTxRMC3mhTA0n7/KPTOzHNQ5 Wakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607508; x=1707212308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RQzBQ4TASuzmiR4SqIUWePUdwbCtW+Gyj+OrWEuWMsY=; b=bYzRcwZrjjvjJerbSKUqEyTek2cEEFCrUysytmGckZz9Zbl1J4DhsH0Cx73CZGga7h dmOl/XjaOZobxowShw59qwBvOpo4n2XuUAgHEInrToX0OMvpx6Bp2A3zYFunWmkuRKPx IgU8b+YmVoKTN2vSbuwuaMBMdnlMIQM9uwAtZOsiL1iUBwD7cUvglyRohSInNO8v7tEw jWXO268R7Rz2fCzFXrp2hlVonXA08erHmDS6aANUi7qDvlLeGktVHUDjlP6mWvn4uGts S6yrbK5h9MXjnnWm1Btr8wGlK7Ujj+59zNPYxI5qjXipxN8IyIt6BfUZtXoUyUFxEc0x Yyrw== X-Gm-Message-State: AOJu0YxTuz1lXl4RsWP5ceg4LtMIpFkU9ewmHNuGaWIyC48Kgqx0pnFU Buydw0BUV5rWKt+waA5OyA+hrGx0JaND7XNPRgFCxbXiGiYgjXMq9Hi/W5HEBUo= X-Google-Smtp-Source: AGHT+IFTTT2SbZmkNKnDsCZ1HUru53gHa0hRj5NRGgC3qt8zxFK1NYKcOop/xbSK8ch3lSKW2/Vf2g== X-Received: by 2002:a05:6402:14d1:b0:55d:43e0:93d9 with SMTP id f17-20020a05640214d100b0055d43e093d9mr777384edx.20.1706607508436; Tue, 30 Jan 2024 01:38:28 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 3/6] arm64: dts: exynos: gs101: use correct clocks for usi8 Date: Tue, 30 Jan 2024 09:36:42 +0000 Message-ID: <20240130093812.1746512-4-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013830_182204_3A9BCB14 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi8 instance here. For USI and I2C, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI8_USI_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and i2c drivers. Update the DTSI accordingly. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- v2: * add an empty line to commit message * collect Reviewed-by: Tested-by: tags --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index bc251e565be6..e5b665be2d62 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -380,7 +380,7 @@ usi8: usi@109700c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; @@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 { pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, - <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>; + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; status = "disabled"; };