| Message ID | 20240201120332.4811-6-rogerq@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: am62: Add USB support for k3-am62p | expand |
Hello Roger, On Thu, Feb 01, 2024 at 02:03:32PM +0200, Roger Quadros wrote: > Add PHY2 register space to USB wrapper node. This is required > to deal with Errata i2409. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> What's the status/plan for this? v6.9-rc misses it and therefore we have this error in the logs (and of course, we miss the workaround). [ 0.583305] dwc3-am62 f910000.dwc3-usb: invalid resource (null) [ 0.589304] dwc3-am62 f910000.dwc3-usb: can't map PHY IOMEM resource. Won't apply i2409 fix. Apart for the error message, the change here seems required for the hardware to properly function (IOW IMHO it should be back-ported to stable). Francesco
Hi Francesco, On 08/04/2024 12:52, Francesco Dolcini wrote: > Hello Roger, > > On Thu, Feb 01, 2024 at 02:03:32PM +0200, Roger Quadros wrote: >> Add PHY2 register space to USB wrapper node. This is required >> to deal with Errata i2409. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > What's the status/plan for this? v6.9-rc misses it and therefore we have > this error in the logs (and of course, we miss the workaround). I will send the fix for this for v6.9+. > > [ 0.583305] dwc3-am62 f910000.dwc3-usb: invalid resource (null) > [ 0.589304] dwc3-am62 f910000.dwc3-usb: can't map PHY IOMEM resource. Won't apply i2409 fix. > > Apart for the error message, the change here seems required for the > hardware to properly function (IOW IMHO it should be back-ported to stable). > > Francesco >
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index 9432ed344d52..da50fbfcce56 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -622,7 +622,8 @@ sdhci2: mmc@fa20000 { usbss0: dwc3-usb@f900000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f900000 0x00 0x800>; + reg = <0x00 0x0f900000 0x00 0x800>, + <0x00 0x0f908000 0x00 0x400>; clocks = <&k3_clks 161 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb0_phy_ctrl 0x0>; @@ -645,7 +646,8 @@ usb0: usb@31000000 { usbss1: dwc3-usb@f910000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f910000 0x00 0x800>; + reg = <0x00 0x0f910000 0x00 0x800>, + <0x00 0x0f918000 0x00 0x400>; clocks = <&k3_clks 162 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb1_phy_ctrl 0x0>; diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi index 8311c7c44cd3..523bab94eace 100644 --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi @@ -563,7 +563,8 @@ sdhci1: mmc@fa00000 { usbss0: dwc3-usb@f900000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f900000 0x00 0x800>; + reg = <0x00 0x0f900000 0x00 0x800>, + <0x00 0x0f908000 0x00 0x400>; clocks = <&k3_clks 161 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb0_phy_ctrl 0x0>; @@ -586,7 +587,8 @@ usb0: usb@31000000 { usbss1: dwc3-usb@f910000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f910000 0x00 0x800>; + reg = <0x00 0x0f910000 0x00 0x800>, + <0x00 0x0f918000 0x00 0x400>; clocks = <&k3_clks 162 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb1_phy_ctrl 0x0>; diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi index 17d28390d587..ae0ab67460b4 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi @@ -562,7 +562,8 @@ sdhci2: mmc@fa20000 { usbss0: usb@f900000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f900000 0x00 0x800>; + reg = <0x00 0x0f900000 0x00 0x800>, + <0x00 0x0f908000 0x00 0x400>; clocks = <&k3_clks 161 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb0_phy_ctrl 0x0>; @@ -585,7 +586,8 @@ usb0: usb@31000000 { usbss1: usb@f910000 { compatible = "ti,am62-usb"; - reg = <0x00 0x0f910000 0x00 0x800>; + reg = <0x00 0x0f910000 0x00 0x800>, + <0x00 0x0f918000 0x00 0x400>; clocks = <&k3_clks 162 3>; clock-names = "ref"; ti,syscon-phy-pll-refclk = <&usb1_phy_ctrl 0x0>;
Add PHY2 register space to USB wrapper node. This is required to deal with Errata i2409. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- Notes: Changelog: v3 - new patch arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 6 ++++-- arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 6 ++++-- arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 6 ++++-- 3 files changed, 12 insertions(+), 6 deletions(-)