From patchwork Mon Feb 5 12:45:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A35AC4829A for ; Mon, 5 Feb 2024 12:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Elu2tsBfZQ+p1pXuXTZalReAJCqhu7og9m9oLIf6fYQ=; b=hwjXyFtDS7p2SO FTr1g/wtPHQGaycsgxvwYRcMRNUNAXejFnMwarKldr0yDUdX+TuXSI+lROkWQRc+pX/Kn/oz/GuGG O4q6m6ghRqFK2ANnZRzfgnCR9OqLNlLr09x7klgAthJ3KXCzYUht1aQhhm0C2IwKgNvfYiRMGbOh7 HrzZctE50+2vNvx+m+ER2fgKZWysiY2d/uEFV49gepSuIFqNfYkbcobkkk5aPWPCG9osHFYnedc9H Ebuguf5p0BqJtsmBo7hucdUvmxRf+1dJsj8QumIqzKOc7JlDbyVhXjdnf6JTykVRrPlR33DTxB6IJ l/lXBXB0iEl+HqZHvP4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMF-00000003GQI-3m1I; Mon, 05 Feb 2024 12:45:55 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G1g-2DCU for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:35 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40fccd090c2so20495885e9.0 for ; Mon, 05 Feb 2024 04:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137127; x=1707741927; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JtonYnG1zvMSmP8RYe4qSrpkG7WWpwfs2mfkmLGPi30=; b=ee9US1D28SOT1Z+xroAVfzEwIQOMwcxQ/upn8rYBFEwwb5qtveCOXJ/G8kNTZBAJbG 4DrZTL+0BspWkLYbuiF5nw/U24V6x1yFl71bcJ39x0gLdgUKzGz8mZWYl2my8WBs3U0B Z8ThDFYSo2zlXuuE4LY9hwlX5b7fIlY3qtvWs2Bc2J8KTrqTm4trQn1YBJP0sc9E6oTz OfoV7b0uOLewMJ6s0JiGTDdpO9DOPoUip4aq6+YZaLHc1oRqxWLHQclQsSo0DPK0kkdO 1bbp4obJmwh2SBi/lQbcJnn1Kq9UD5piu7RFcisd/2eubEk+kj1tsMPOKAYbGH7MyPka wUuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137127; x=1707741927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JtonYnG1zvMSmP8RYe4qSrpkG7WWpwfs2mfkmLGPi30=; b=TYeVdOYQW6RSw2EJ6xMi837ODjSp5rR7NbQqhBe4sDh2pfCKpn8GMivrI860vSHXBT 3v5BK+3pwWZKxWicfoqLZFKJgnGg6oqVBtaX+u/AcqdZFciy/CuQj3qyFFniz1n9S+Q7 C3DwA5CMamwKQP6GOLBSU9nk9TLvUIZBlX0GHbHRtdADys2r1MXlzNHREdU0GPa38dwA dArO+YmcGAcL0MeV8y/cQbW5p6Yqi9/ahTAfQyHF0WVrLHOxuR9q09Mk8fLAGkWdyd8h qnYtCgMm8uDi0ytkY6BGwy6z/G+TP/c1zAqriVxW+9uSdfzbfU9iRqYE5taMpQBGLUFe tptg== X-Gm-Message-State: AOJu0YwLz6qCdZr4DBaW1CSrnJ2NkuwcExvY3Qwg4KccW4Bx7OjC+GP5 r/9/9fGHAoCEj0Kd8QUggMNpLjPNOz/As09keXcPrnls/53P9T5GzVDl7ILg0fg= X-Google-Smtp-Source: AGHT+IGvOiXo7HPcAuCueUfCXl+hW1dHjHJs0oFybOPNePVj78Eq7mqkrITmY1dHKEpvtlR/onCLSA== X-Received: by 2002:a5d:628e:0:b0:33b:1494:e4cd with SMTP id k14-20020a5d628e000000b0033b1494e4cdmr8738260wru.3.1707137126957; Mon, 05 Feb 2024 04:45:26 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUnB2TnwxP2m+P+k2osg80LUiFMk8AYW9KKJixyKCil1SFvymbNwDnyv5aGOLjkdFIIat4WmSO7a4JXLHXn3VISSvM+7RVQcg0Pc0Fb9CO2WjD9q2jAPVAk+Y81aHewTEE1IiAUbWO2KdsWTh+EVlqaA26G3INEN+MW5DD//ZHCIBgpkDe+Q1yXqKZwi7+TZV6oZgWxpLWtlnC/vbOnnxR5hsTMrwcDUDdAcOhChiLGv2Cy+Fee/HbCH/Faz0FVfeE/fIgfQU1IizkzZZUkIk8biLIW2rCUJFI6sj/09hijvYqXudHO+D77AWOHBK8Jgy5aZtvLBRys53v9c3/ru4AGJtK+iGd5tYVFx0GPzDwqTGRYDcIPSQkBIOWaeLWHB0eNBql9MhxloRoKEj+AwfvCosH7A5tKS0fuUekbdm/MbC19l3fiGQbqdyjkJ62nOFmMU5HkynyBAYQUxajpBYqcz0FL95kIBqlij49YqJmlZcSsEDOd9WIc6DBH3g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:26 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 10/16] spi: s3c64xx: propagate the dma_submit_error() error code Date: Mon, 5 Feb 2024 12:45:07 +0000 Message-ID: <20240205124513.447875-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044533_670537_C231AC18 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 43b9792988b6..7a37f5d0abd9 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -321,7 +321,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch);