diff mbox series

[RESEND] arm64: dts: mediatek: mt8192-asurada: Remove CrosEC base detection node

Message ID 20240207-mt8192-asurada-cbas-remove-v1-1-04cb65951975@collabora.com (mailing list archive)
State New, archived
Headers show
Series [RESEND] arm64: dts: mediatek: mt8192-asurada: Remove CrosEC base detection node | expand

Commit Message

Nícolas F. R. A. Prado Feb. 7, 2024, 8:08 p.m. UTC
The commit adding the ChromeOS EC to the Asurada Devicetree mistakenly
added a base detection node. While tablet mode detection is supported by
CrosEC and used by Hayato, it is done through the cros-ec-keyb driver.
The base detection node, which is handled by the hid-google-hammer
driver, also provides tablet mode detection but by checking base
attachment status on the CrosEC, which is not supported for Asurada.

Hence, remove the unused CrosEC base detection node for Asurada.

Fixes: eb188a2aaa82 ("arm64: dts: mediatek: asurada: Add ChromeOS EC")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 4 ----
 1 file changed, 4 deletions(-)


---
base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29
change-id: 20240207-mt8192-asurada-cbas-remove-ca5e1dc89b5a

Best regards,

Comments

AngeloGioacchino Del Regno Feb. 8, 2024, 9:24 a.m. UTC | #1
On Wed, 07 Feb 2024 15:08:42 -0500, Nícolas F. R. A. Prado wrote:
> The commit adding the ChromeOS EC to the Asurada Devicetree mistakenly
> added a base detection node. While tablet mode detection is supported by
> CrosEC and used by Hayato, it is done through the cros-ec-keyb driver.
> The base detection node, which is handled by the hid-google-hammer
> driver, also provides tablet mode detection but by checking base
> attachment status on the CrosEC, which is not supported for Asurada.
> 
> [...]

Applied to v6.8-fixes/dts64, thanks!

[1/1] arm64: dts: mediatek: mt8192-asurada: Remove CrosEC base detection node
      https://git.kernel.org/mediatek/c/12356a73

Cheers,
Angelo
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
index 6867c4ad04a9..9b738f6a5d21 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
@@ -1337,10 +1337,6 @@  cros_ec: ec@0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		base_detection: cbas {
-			compatible = "google,cros-cbas";
-		};
-
 		cros_ec_pwm: pwm {
 			compatible = "google,cros-ec-pwm";
 			#pwm-cells = <1>;