From patchwork Wed Feb 7 00:23:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13547938 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3931EC4829B for ; Wed, 7 Feb 2024 00:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BfHkJW9Ifo7Ed+E+ImoHhjJJ2izExhUyr1OWMPfOO6E=; b=dCOXpLFXt45XwI SpQ/nBqgIS7AWrFGQefprvOuD7dXYwXPt2j7A33ankFwwoimd2mW8NbsEBwY7jqxkLJ+b1h3/h+nB 8ecyKOMMsAxqfTfvB+zUuMd8GCD0zThVEGuwiTXYBcUQMHjutirPYLgMArGMmmJIz5VM59WC5eaXG BZdkPYzCS1xfXu5+tOegdYbTyqx2HwTh59dN1qD/fn8A3d1H6O0hK/fBqXo0MapuKtrUjNuqaUQug JGqewRVp951di6TltSiQiX0c7LLo6ZqJTN+JjPrNVVS6w+drnTrIYlp5/5R8LA3vQFNJSmGmQP/BR vTiNzF2pXhSTVok4bQWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXViz-00000009GPe-1cbW; Wed, 07 Feb 2024 00:23:37 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXViw-00000009GPF-2nUN for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 00:23:36 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-783f553fdabso8302585a.0 for ; Tue, 06 Feb 2024 16:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707265413; x=1707870213; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eJn6nkq8Q6d0DBnWdQTTcqf1BYRrhaP04tM4LL1oFOA=; b=WGN0jmS4JqN92qzuCCtItZ5He5OybSpDEhDjBwhGLwAjWtpNwQPbckAskS+v2qnaIH ttHJ+IwkRBZn47CjanB25aPG8v11Unenq6ND5oyLFQZQvYwqN9W4I7PtUXuwpyl46Ot+ eUsfpQlDGSBfOpyLZBN8xk+XrNh7uuQqbS3RM9zrgH0kpj6Bf37Js6wquoQHCk6SOzXm bImQ2LOKiH+1PPY60D+1HMFxkoQfQptEXYWwaqPM8DdpFTd2zjnWvc8MEBJ27ZPjcgHU hskqUh+0NFt3XpJvmGUy1Ek5ewqEqXqcpnljkHzT2O2p3I5c6XpmaZPMjnr07Qgy8rwq 0IUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707265413; x=1707870213; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eJn6nkq8Q6d0DBnWdQTTcqf1BYRrhaP04tM4LL1oFOA=; b=C0PGdUxzhnsG3ERjYGpjm3nPD6cJcw+wvTQYQmxIxY2iGmXMloPcPJEX4Y6MbE7BSC Mjlpc7UZwCieYlRqanqUjXn3qBN3HcsvElR80GgE8UZZN2pv72yI/SwJ7gpteL/mh7vz GA+Jv8bXS/BgHJmUHoaG6LjIoJq6iNeac9wX8L15yIhsdbZRtcSSOlqPCgnytBVR2ZDv f5bSIjzaa87ZYcYlsC5aF8EzYWwU2IyJBdh+4zK189EJO84SvDHLzf4Tu9C1cusj+ito mjvKt67YokGuKnGcDeywR2sDkECoBWqpxeduasFuIeSclgqGkF4bMeaA54Uk+BMJhZiP 7Lhw== X-Forwarded-Encrypted: i=1; AJvYcCUb8wij9p3caOo+rPGUQRoB+i+7XwR+E1vEn23bwzwOJxxLHZS9Kpb3SM5dN65j6Wfc4Ptgc1ux/hdaM7kZC3IIk6aU7JtX3DPUDhG0B1JqZ9nl90k= X-Gm-Message-State: AOJu0YyEF0KEXh9oyHA0jtWt+hhrecJHvc7ZtkUd5RgDJ+lNh2EU6L47 Ca21e62RDwn+VaoB8lr6HLQrnBg3KeGqE4ozoJXIzg+0I3NFgiDm X-Google-Smtp-Source: AGHT+IHV6b1vWGsHIG5WoqcXN3fD8F47EWX0hNDQoEfiBK6EZgO4A05HU+eku6RwOHEX+NSQKmNNpA== X-Received: by 2002:a05:620a:5601:b0:784:2f2c:7b47 with SMTP id vu1-20020a05620a560100b007842f2c7b47mr14647406qkn.17.1707265412990; Tue, 06 Feb 2024 16:23:32 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUKqAZHciSBhjDkL93HSNwomj8WPup6WGlhY7hcp1+bBepyowCJcME+5DvSiTwCuo4I9OvgseJ7gAdxnopaPEgkDX8LvizgVLIp2x2/Xs1qLL4FLcCbxnhahVbF8hiWWVkL99ea8y/zdB6M8xSfrwRlh/aAkjyZZmwTaoWMLdmJD6M7ad9d7RRfYcf5B2Ih8lXWb0RsFCOtN+PE6kWS8zYacyOqFWvlbCaeKJWuVJ9SoK0J3UiOka/zQ+kEwLo1HXwEfGA2yywLwxlu5qbkXEYOwW1QIc14kPcx5EZlq09ObakrYL82tqDJfe16I3syDAwo4i8TKCrIC9NvdJrWuwDOqUD5r1TK/PONOfaVU6sYB8NNIpwqBGBtmBpyQEuuH7OTM7a+9gmZP1ycnmj1/uNpK1iOE0Jov4vAizwLDfVvhx85mOeF+VHPx0NBLWFTsJcyaAv6+9dioJ9m6vqA6+AbFjdPmezodvhrt+8Poit681nKmCj6QRsERdN0a5GoL0l0QtebUF75dKHYeIpfFcZL9xFsiF1OQLiRkIvgFy6KK+lBwp5YMq9LqVciGT0czfprTjMKQE9uu/IAfm3IVHO/JlMLXDexfEoUFwvkGnnqrLAQ06JxSbEirKbJVTqre71+uJ2HZOd9h/5BgWCzkR8Um5QhFpSL68WBpP3D8YyGwClGAK/UzDoda4xqCdYXIGuDkz/AWOdE6nFBpbnYIRP/isjJPgczZPjZugWy1Cicc3CW6TG+wpIREtKVYMGlroiBW0ShOSY9p8ht Received: from aford-System-Version.lan ([2601:447:d002:5be:a4c9:b449:4b2a:fb09]) by smtp.gmail.com with ESMTPSA id s9-20020ae9f709000000b00784b5fc8f1dsm30107qkg.34.2024.02.06.16.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 16:23:32 -0800 (PST) From: Adam Ford To: dri-devel@lists.freedesktop.org Cc: Adam Ford , nathan@kernel.org, kernel test robot , Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Luca Ceresoli , Lucas Stach , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings Date: Tue, 6 Feb 2024 18:23:04 -0600 Message-ID: <20240207002305.618499-1-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240206_162334_733209_7B8D3ECB X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Two separate build warnings were reported. One from an uninitialized variable, and the other from returning 0 instead of NULL from a pointer. Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface") Reported-by: nathan@kernel.org Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202402062134.a6CqAt3s-lkp@intel.com/ Signed-off-by: Adam Ford Reviewed-by: Neil Armstrong Reported-by: Nathan Chancellor diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c index a76b7669fe8a..f2a09c879e3d 100644 --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c @@ -57,7 +57,7 @@ static void imx8mp_hdmi_pvi_bridge_enable(struct drm_bridge *bridge, const struct drm_display_mode *mode; struct drm_crtc_state *crtc_state; struct drm_connector *connector; - u32 bus_flags, val; + u32 bus_flags = 0, val; connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); conn_state = drm_atomic_get_new_connector_state(state, connector); @@ -110,7 +110,7 @@ imx8mp_hdmi_pvi_bridge_get_input_bus_fmts(struct drm_bridge *bridge, struct drm_bridge_state *next_state; if (!next_bridge->funcs->atomic_get_input_bus_fmts) - return 0; + return NULL; next_state = drm_atomic_get_new_bridge_state(crtc_state->state, next_bridge);