From patchwork Wed Feb 7 12:04:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B58F9C4829A for ; Wed, 7 Feb 2024 12:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xu0HDdlU8HvywPQFqg5Ls7UBJKZk08fEf5QZb/uQvvQ=; b=dTS5qCPta/nPhi 9dldxpqt6CWM1OwewY0uThwf/JdBBOYpp3bQ0gR+e4WQjIE4Joz6/TLk6y9FL1tvcUY+BqIRw4jxl f3ElJr87PSIF8MyYAflpEF9pVn3E2iL9cAdmrnXy6evPp5hBNdvyN+FCPRLl2wTnkSNYajNw6P2hQ hr+ULdcDT5FOu+KqIcwt1NGQwK2b4INFBDCx85KYBK7Z2L8PSV35UIbIWC5rxGnTPZuwY2GT6pzeH M02Ltzvcs3A01o1RwAp1HwR5K+6MxdPuIu6DfebqzAH6m9YUC3uRctDyLCPfclZEGZ+N5/7IXog2O sH/zevVJUjM3WVNEoQGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfy-0000000AZXc-1sE5; Wed, 07 Feb 2024 12:05:14 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfa-0000000AZEU-3Js3 for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:52 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-33b4db36eb1so411415f8f.0 for ; Wed, 07 Feb 2024 04:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307489; x=1707912289; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=fIYF6D2/yGBxZlcxHNImDT1ngv/AFrQC8ETg1eE9A6uAOxbbaH+7elv1smu1vVqyOr JpmqQxqUMWHs+WJc6WgslrjNyB2cpZy2IucWx+umqzDJs7LURRlsNR0uqbVnY+8W3ToF OMV8ydlYrxZL/QwnwOHVGF9Sq8pedE3lcSR8PxmH36zWcreIeMiD/VheNFQufYlBJel+ 21gE/m4idZ8YH3yn4eFo372soJp6V1j46Ea/L+EVzZKOA0keCsa65xuX5KSq2dDbNUwO HWRujVaV7HTnUhj3K80wB13o37VrXFQhmJOY2SjQK8PvwJCCm0oDnhJFvD+dWoyZUYt0 siUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307489; x=1707912289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=jlSlo159qSH/3l1JJ0ezV9LrCZl64JYU4MNxeHNqaOqt9xp461htL2c9gzIS/lqjVP QvTkJzylJLbnuTUmdMaSVrGlDnqhrkjkRJhb/nK4bdIc4JoPHfosThGPhnhB17BWZmet czvTkypB7Bl7nH+JFinCsLNzWbdMY5zvVPvjAzmp5lTXvXw4+56G+mZwrdCcZ2djFvTS T9JZemYhR2mwI0m9WVH6pQpUoV3DJEjfPVpSREXOea1r6LXY4AjVMvSuoROR7nHb7FW/ FYp45ID+5MMWzYkPQDpedmlmRU5ztxW4xd7z5kJw2NCBp5H9osnhtigjfXyUS/LyJT4u /fWA== X-Forwarded-Encrypted: i=1; AJvYcCWkklh2pE55schd+nzwfhhWQ6p0q2LBinZFJGd7nVtkJ+c8ROMrYcOAhH5EMn9r5L5U/g5aoJGZPQjb5ed59HvBpDDG8br54k7FVIGBuqQgx5Qkm58= X-Gm-Message-State: AOJu0YxPBaPdbD/81RpWvHQmCjgBJKhR0KVfmAktIAPYudIiOrqNdDE4 jL/WFPy29pRIkddZ8xPZrV2rAwNABBLwAHZk+JQh2E9Wu2GsRGMnCckVLlwMz1A= X-Google-Smtp-Source: AGHT+IHLdYTOpuM6YVl5VQ8KSmozpR6YZJf1vCyR7Jm7pldciiKf3Zxcsp8BxcHt6HVkzpmmahJfLA== X-Received: by 2002:a5d:6989:0:b0:33b:1ae4:10be with SMTP id g9-20020a5d6989000000b0033b1ae410bemr3112553wru.46.1707307488917; Wed, 07 Feb 2024 04:04:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWPoi9waljrhcc9Du9f7ChdJiFb7bX6DdMzhB6TZiVx1S6gG/nPe729BwNqPKcVyZuuPdA0jWoPjSZwBlPwgoGv4/+7VcutaOWWT7HZ/3E8KzjuD0LOtpjL0KJJBvdcnNnl7DjKH9MgkFM+oOQxMagBpYbUSNp+A0jDqH8NN2oxDXjkv9Czp7X62NXW5WDOIraHpUkXlQrhFTumVMhvNi2/fuvQOmrhzuwXTN5b0Xg+BD8zux/iMilXXTbwuTHqAP03e4h0gtwf0TXw8YZnH5aDaUAcLltEVIOw3dI8iuambt30B7iLPUkTQcl5whcPC6+OBnzA0glExTxAon0OgcvfTnCNygZplHw+HOEJkdkfLPNEFmao4a8VIZQiPLVaARwFsy4ppTJHvaD9+xssFBf4zYZUcC60X4vqjIWfKWGON6SA6CBFPOQg56CTSps8XueWb71vVnuDitaohl0PNzBRtFUQfoQZtyrmFl5+hfaKawwtkHi2Hh19s739xw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:47 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 11/17] spi: s3c64xx: propagate the dma_submit_error() error code Date: Wed, 7 Feb 2024 12:04:25 +0000 Message-ID: <20240207120431.2766269-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040451_036537_E813AED7 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1f7356f6e5d2..ba17c5a04eef 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -324,7 +324,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch);