From patchwork Tue Feb 13 10:12:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 13554907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AD80C48260 for ; Tue, 13 Feb 2024 10:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NeX1AnCrSgy3VUiu/xLx0gYMLpUiR320WMT6PBejavk=; b=yDQ3Jpj4lTfwiK /tlGMOFHV+oK795hQGtlCetnbdruyg6yBXk4tLKOcqqPbOWOQdoGMvoLoHQ4qcp90gex1XchskLlP yJcsvbA+VtwATUPPz24sT8t0j+0HAgdJqxbBcJ/t+DiSIFv6QOYGmVd87NHcsgF+haM8ZnX2KF1IB AtKsThsDzXHvSsfkiW4LK/liMrA7VqRAHCVq5BEcCjSHIqDgNOHmM5irj9C4+txMFL4iXLJM3LC8c UK/lynegXYBFktX28iHjV+S6wKO9PDbO5KglRWGAeI7RU5Q8g2cv4sMg1EBS1jsfLdk92zWhjaQUA yZ7scDByb+FFXQvQo8/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZpm6-00000008mNd-1Pin; Tue, 13 Feb 2024 10:12:26 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZplv-00000008mL0-35Z5 for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 10:12:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1899CCE1ACA; Tue, 13 Feb 2024 10:12:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54CD7C43394; Tue, 13 Feb 2024 10:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707819133; bh=FYsp97vFbDiqatkf1UqYPH39ft6E0mUS7CzZXsJpk5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WarX6W8402RK6EJ2bQjfEIFEb6JGg4S+xOhyWQYRFC2bV92GNHC6kZmpSPzvetnZ1 czegp3GfMGUbkOZ05z3gVzKTl+q2e6vuny672EFAG+dukKOyhTajePpDqCm+rlADYw Cow/zY0fupw/WmtF7NULqrO/QEdf5+yvtjC36YxrHOEG/7l3pProD0qc6elNTBae0R aTlu5A9zJtXHswKxhlZyqOMieezKWlKW5ea1RsZp5NlglFxi606j0bU3GDjWys2UiD L9MRjvZRLQASGUJkcDFxqUnZDfeGGFnVGhikGcBfFl99F3V2ggDmcWQ3+L+ikUOh+Q ohZJ443Dg4NEg== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rZplr-002j7r-4j; Tue, 13 Feb 2024 10:12:11 +0000 From: Marc Zyngier To: Thomas Gleixner Cc: Kunkun Jiang , Lorenzo Pieralisi , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/3] irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems Date: Tue, 13 Feb 2024 10:12:05 +0000 Message-Id: <20240213101206.2137483-3-maz@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240213101206.2137483-1-maz@kernel.org> References: <20240213101206.2137483-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, jiangkunkun@huawei.com, lpieralisi@kernel.org, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_021215_971209_2E25849C X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While refactoring the way the ITSs are probed, the handling of quirks applicable to ACPI-based platforms was lost. As a result, systems such as HIP07 lose their GICv4 functionnality, and some other may even fail to boot, unless they are configured to boot with DT. Move the enabling of quirks into its_probe_one(), making it common to all firmware implementations. Fixes: 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node") Reviewed-by: Lorenzo Pieralisi Reviewed-by: Zenghui Yu Signed-off-by: Marc Zyngier Cc: stable@vger.kernel.org --- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index fec1b58470df..250b4562f308 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5091,6 +5091,8 @@ static int __init its_probe_one(struct its_node *its) u32 ctlr; int err; + its_enable_quirks(its); + if (is_v4(its)) { if (!(its->typer & GITS_TYPER_VMOVP)) { err = its_compute_its_list_map(its); @@ -5442,7 +5444,6 @@ static int __init its_of_probe(struct device_node *node) if (!its) return -ENOMEM; - its_enable_quirks(its); err = its_probe_one(its); if (err) { its_node_destroy(its);