From patchwork Fri Feb 16 07:05:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13559621 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98E38C48260 for ; Fri, 16 Feb 2024 07:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/7H1si7vcyafJTpeuI55OQQzJK+WkQgd9GrEVTLCVyI=; b=e18tSKljh/Ymk7 5eVShWlzgPgBkgtX3Z8dTCg/utnzW/0n9k5K8UyMeGsGgObDRKAo9qDtUoNB+7BZwKsHtYevF6Le8 +bVdFWTOT5CqzusaBD1/RoGmn1cDUemEtwfh0dM0yKOANg3Fs0JI3pzfnlGq2ffEtaFTgcDc8LVJ2 Cr27Xwgfom4T3824ShgSy4XT77Wp9tmzeyWmrgLeeqdhy0MJZQLYuDTtSmrTFDI64JPjsLuF1zprb 167jZhswBn1n5HjavFK4U51K5xRyePEmPQeftSf29e3ffSjE92r0dAGSYkejT1c24E8OJMDZ1qTLo aXq15eVxEY77TJXxy0NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rasIm-00000001JNJ-0giV; Fri, 16 Feb 2024 07:06:28 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rasIV-00000001JBv-0wcZ for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 07:06:12 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-33b29b5ea96so802243f8f.0 for ; Thu, 15 Feb 2024 23:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708067170; x=1708671970; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WkqCfr2t33L8Q9VhOTDSxHGDf/6G9Yy8lK28zIkEPyE=; b=bv/Xr9lx7sMUl9443ZUb6AQmySffMXGRhJ00xzNaRSS23fiANT0oHrw4NSU5FxnT07 Z3fg9CI7xXY7Vjp/u2mHuYuayTfCQGWW70ag0BQHOXU6+nf52uEMViEDKMpJ1lUsg0T3 dNCWLHZ9rnSWE72bTyM3SJzrq2QruLLiRdPIVJwhyksW55oG2xAhx5/K50/UMPxW4e30 FuLlmIAVCKR6k1xCpWvpWgzUGeEuwcSLM/Q298nBLgPFt6K/Eu+YyALotoSqDhEu8dQb BPJUozEqYALqTeH0k5qWyvqVo22I/ykauGGGccBbyPxHc2VihWb6kTEKtFvWkcozGVzd mwYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708067170; x=1708671970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WkqCfr2t33L8Q9VhOTDSxHGDf/6G9Yy8lK28zIkEPyE=; b=c9Z2BnmacKM/LYWj44qq7y5GUOvuj8/bcfjnlXClQM5wf/BOB0uS7RLYDQ/wOloMzk R6wtid9Q2FPoya1uuZqEaTob4A3vfQ1dB3/GdpEYqIa7N7gq+Z1nUKWkAW7F1WiGww8+ 7njr6yNoV6JQv4ign4omqtUkfYT3fb4pkhdGH7+VV0XK14RI+sOl8ob/YG4qWitpTDDR 9jk3CtzeDKWyeoD98fJFQjbbFDeJuRiLVeZl88YWqpTbNCFYv2S0GEPRabgda2+eyFya Krrqnef434bsuxMpFDw15n4Zu83qEoKHd/BKf3sy8OR9temm9mVjPd+r03iD0t8jJuAL igsQ== X-Forwarded-Encrypted: i=1; AJvYcCVHUw0N6D2pdBIBlGZbm0x3K+U8pLl4KnPL5jYZxAyIkYmCda1SCxJgRhgdRs9LsXcoq9XoC8k8w7nVTMeqQIAI737MXkTDw5YlMLtG2sYzglD2m2s= X-Gm-Message-State: AOJu0Yw2q4cM6VfqKHWgsD93FWM1iD+iK42x8yPiJOVgZENWGZORkq4M fLcdW7ThKVFam1SsvBB9VgrKTqalFWF/mu2sC+FRkhhreA7E0wfgQa3HGBcVlPA= X-Google-Smtp-Source: AGHT+IF9IXKPA/Y+ft0Qy0meyaCsdXG7oVlLehuRlTmOGdJbKOq6m4Wlzxzotfb9H950PZa7V7UfDQ== X-Received: by 2002:adf:f706:0:b0:33d:c45:15ec with SMTP id r6-20020adff706000000b0033d0c4515ecmr3396246wrp.32.1708067169974; Thu, 15 Feb 2024 23:06:09 -0800 (PST) Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0033940016d6esm1298839wrw.93.2024.02.15.23.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 23:06:08 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, Tudor Ambarus Subject: [PATCH v3 09/12] spi: s3c64xx: get rid of the OF alias ID dependency Date: Fri, 16 Feb 2024 07:05:52 +0000 Message-ID: <20240216070555.2483977-10-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240216070555.2483977-1-tudor.ambarus@linaro.org> References: <20240216070555.2483977-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_230611_301788_C45A807C X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Compatibles that set ``port_conf->{rx, tx}_fifomask`` are now safe to get rid of the OF alias ID dependency. Let the driver probe even without the alias for these. With this we also protect the FIFO_LVL_MASK calls from s3c64xx_spi_set_fifomask(). Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 40de325bd094..d2d1c9767145 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1203,8 +1203,12 @@ static inline const struct s3c64xx_spi_port_config *s3c64xx_spi_get_port_config( static int s3c64xx_spi_set_port_id(struct platform_device *pdev, struct s3c64xx_spi_driver_data *sdd) { + const struct s3c64xx_spi_port_config *port_conf = sdd->port_conf; int ret; + if (port_conf->rx_fifomask && port_conf->tx_fifomask) + return 0; + if (pdev->dev.of_node) { ret = of_alias_get_id(pdev->dev.of_node, "spi"); if (ret < 0)