From patchwork Sun Feb 25 11:38:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Kanzenbach X-Patchwork-Id: 13570804 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D729CC47DD9 for ; Sun, 25 Feb 2024 11:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NJTi6Bovg3iU6j5GiwWDxR1MBZc3PN327taohh86Ch8=; b=TRaqzNwfOcdVm9 A/1dLgxKDa3EH1+SVVuzn9oZc4wEDtXd3tkYB9dqI22IYzRzXAnRUetkkaVrtkRphdy0GpMvQcWf7 gzm1bTemPFKIv2iF7xnvfxyqvDh4NLyZSFG9YQHoUEKizO7gg8us2PXBXL9L7dLJy+eVOOfISqdv2 9WXAkxdHDG8yHjTctZZ5W78uZWTDXENryxp4Qo/THIziupuAtVwsdMlni6pECdBJkRJ5K3H8TKgdr vYS7+hSsASzrLJi85TdKsM1Myb75ed9FGC7r4PqFPMCclAhu+YGQA9RAM+LyJM1/pHWgMdvgEAw0y 1DbcEaeOneoHJJVkrn4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reCqF-0000000ErNL-2RQb; Sun, 25 Feb 2024 11:38:47 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reCqA-0000000ErLv-2fYy for linux-arm-kernel@lists.infradead.org; Sun, 25 Feb 2024 11:38:45 +0000 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708861121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Nd1jp0ik0EQ8lB4/a6qsMXOn4vrUpwGeAyAe+L+hO74=; b=2Kl/5+Vz2RGNX9IRizM/tRprQhU4nMEu8+jdI/nwr0dXIDCI62kr4l+QhcvCILGd80SVaH DC6u8JNDYaV8iyBldD0qlo5h4WrY5VxvkXSaCHnyiQPaFZ4olgaaE7RvlUFRJZLmFvup1+ L9V+9ahaQwCwwiqymU0U+TkTwOotKgFoV8Igi6UdB5SeTQVvcuriXBpmHaEyDZv9P2sq6X UBzw/nn3eJpc1Jkm4FG3kA+zUxiLw6NAdPiBQEEa2yYCnlA9tLF8gwx0PRZQ1BfiDBEvQy uzcPKSylBqADmG/yWPx7kCYxMn6bAvojJCnA6NlXeKR78N/ZMXaWKrGpMkQwaw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708861121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Nd1jp0ik0EQ8lB4/a6qsMXOn4vrUpwGeAyAe+L+hO74=; b=bgRHsuM6ku0+shTnNChydhV6wAmCSP/Ocbdf6eZIfn7IMUd9PaXfAho5W4iOE/wlPp2jjW CF5eHWjPceLFAzAw== Date: Sun, 25 Feb 2024 12:38:37 +0100 Subject: [PATCH net v2] net: stmmac: Complete meta data only when enabled MIME-Version: 1.0 Message-Id: <20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de> X-B4-Tracking: v=1; b=H4sIALwm22UC/22NQQ6CMBBFr0JmbU07iiIr72GIaelUJpFC2kowh LtbWLt8/+flLRApMEWoiwUCTRx58BnwUEDbaf8iwTYzoMSzREQRU9/r9jnbUZRVScapSyXNCbJ gdCRhgvZttym9jonCdoyBHM975QGeEjR57DimIXz38qT2619kUkIJqixaNNebc/L+Zv9JYfA8H y1Bs67rD1hDlJbGAAAA To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Song Yoong Siang , Stanislav Fomichev , Maciej Fijalkowski , Serge Semin , Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, Kurt Kanzenbach X-Developer-Signature: v=1; a=openpgp-sha256; l=1989; i=kurt@linutronix.de; h=from:subject:message-id; bh=nO+yNgUNWjiWE9FvprklDXQiq6XovnJDIndTRXHt+DI=; b=owEBbQKS/ZANAwAKAcGT0fKqRnOCAcsmYgBl2ya/itUaWlWcQlzoS007kcDGfWCQqL9H4sNex 3nznKAs996JAjMEAAEKAB0WIQS8ub+yyMN909/bWZLBk9HyqkZzggUCZdsmvwAKCRDBk9HyqkZz gq63D/9a5xGEBWftDOSIqgb07v1rM8qCP849lIzLis3u5Ys3mwrMSOkDkpj7seZVvzwdqLlMQ5H 3kcwf6QyiEUXWtabPlmdv2tlBWvmnNS5zQMxu+mlnoC4RS7xAarFnIzcNVaWijGQVpKnfsq69h3 ZI41n+YI0h9qFJzVObhyifR5u8YJuvzxzHLWsi/npuyGNPYLaWSlS0TL5n5uyDqqH6Kg2KaR+PL lTjrwlgNpyKqLJvziYwNDijD0EEmf+7BLYAwDpdD3Pt73WCvpqmKds/M8Khp0qbSwiBS5D9iLRD 5dAlmBG9rpZ8Kr6Y1DtYy72//A/FKECZMbt9HZ0mtIRVfBTyEOnJMmIbvuCbi++KLOa+jsEtOFH xot8ftlqcJRQD5oSOFjBi7LAzGRzxJsMlItbwjNx7pP90dePaAh3VJFGalLtWHX/Rk6/25MIIIQ hgvnGsXM/ODxS1FqXLl40YJqe/r0+YzGY48UOWGNuDihY9P3/cg4RhbQmtuVveN1Oz4ap3QDaEN x+Q6johoucfQ5yFexV5XjUs9VzCfWCOefLfRFLV/u2zgY5+Ob2YjpQ+B1p4AmTiddeEduUBieyK T9TOcWTZ1R4pFX0JnT/TGcJTV+tPJnkd9c6CbeDyzNZxwWAfxHQqDk0RBoseQ/gqGAQJ2/AyhRY 3QO4vT04ftJz5vg== X-Developer-Key: i=kurt@linutronix.de; a=openpgp; fpr=BCB9BFB2C8C37DD3DFDB5992C193D1F2AA467382 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240225_033842_857569_5C13783C X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently using plain XDP/ZC sockets on stmmac results in a kernel crash: |[ 255.822584] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 |[...] |[ 255.822764] Call trace: |[ 255.822766] stmmac_tx_clean.constprop.0+0x848/0xc38 The program counter indicates xsk_tx_metadata_complete(). It works on compl->tx_timestamp, which is not set by xsk_tx_metadata_to_compl() due to missing meta data. Therefore, call xsk_tx_metadata_complete() only when meta data is actually used. Tested on imx93 without XDP, with XDP and with XDP/ZC. Fixes: 1347b419318d ("net: stmmac: Add Tx HWTS support to XDP ZC") Suggested-by: Serge Semin Tested-by: Serge Semin Link: https://lore.kernel.org/netdev/87r0h7wg8u.fsf@kurt.kurt.home/ Acked-by: Stanislav Fomichev Signed-off-by: Kurt Kanzenbach --- Changes in v2: - Add more details to change log (Maciej) - Link to v1: https://lore.kernel.org/r/20240222-stmmac_xdp-v1-1-e8d2d2b79ff0@linutronix.de --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: 2a770cdc4382b457ca3d43d03f0f0064f905a0d0 change-id: 20240222-stmmac_xdp-585ebf1680b3 Best regards, diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index e80d77bd9f1f..8b77c0952071 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2672,7 +2672,8 @@ static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue, } if (skb) { stmmac_get_tx_hwtstamp(priv, p, skb); - } else { + } else if (tx_q->xsk_pool && + xp_tx_metadata_enabled(tx_q->xsk_pool)) { struct stmmac_xsk_tx_complete tx_compl = { .priv = priv, .desc = p,