| Message ID | 20240225021812.4834-1-takakura@valinux.co.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64/kernel/setup: Update comment on interrupt masking | expand |
On Sun, Feb 25, 2024 at 11:18:12AM +0900, takakura@valinux.co.jp wrote: > From: Ryo Takakura <takakura@valinux.co.jp> > > DAIF_PROCCTX_NOIRQ contains FIQ bit. > Update the comment as only asynchronous aborts are unmasked > and FIQ is still masked. > > Signed-off-by: Ryo Takakura <takakura@valinux.co.jp> > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 0ea45b6d0177..9b9fdb64c684 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > dynamic_scs_init(); > > /* > - * Unmask asynchronous aborts and fiq after bringing up possible > + * Unmask asynchronous aborts after bringing up possible > * earlycon. (Report possible System Errors once we can report this > * occurred). > */ I think we can further simplify/clarify that as: /* * Unmask SError as soon as possible after initializing earlycon so * that we can report any SErrors immediately. */ With that wording: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark.
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 0ea45b6d0177..9b9fdb64c684 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) dynamic_scs_init(); /* - * Unmask asynchronous aborts and fiq after bringing up possible + * Unmask asynchronous aborts after bringing up possible * earlycon. (Report possible System Errors once we can report this * occurred). */