| Message ID | 20240227173526.710056-2-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: rockchip: add missing interrupt-names for rk356x vdpu | expand |
On Tue, Feb 27, 2024 at 06:35:26PM +0100, Heiko Stuebner wrote: > The dtbscheck reports a warning for a wrong reset-names property for > the i2s2 controller on rk356x socs. > > The other controllers on the soc provide tx and rx directions and hence > two resets and separate clocks for each direction, while i2s2 only > provides one reset. This was so far named just "m" which isn't part of > the binding. > > The clock-names the controller uses all end in "tx", so use the matching > "tx-m" reset-name for the i2s controller. > > Fixes: 755f37010f3e ("arm64: dts: rockchip: RK356x: Add I2S2 device node") > Signed-off-by: Heiko Stuebner <heiko@sntech.de> This fixes the other one of the two warnings I get for a newly created dts using rk356x.dtsi that doesn't mention &i2s2_2ch at all. Acked-by: Uwe Kleine-König <ukleinek@debian.org> Thanks Uwe
diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index 6a9bfb0550c04..92f96ec01385d 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -1124,7 +1124,7 @@ i2s2_2ch: i2s@fe420000 { dmas = <&dmac1 4>, <&dmac1 5>; dma-names = "tx", "rx"; resets = <&cru SRST_M_I2S2_2CH>; - reset-names = "m"; + reset-names = "tx-m"; rockchip,grf = <&grf>; pinctrl-names = "default"; pinctrl-0 = <&i2s2m0_sclktx
The dtbscheck reports a warning for a wrong reset-names property for the i2s2 controller on rk356x socs. The other controllers on the soc provide tx and rx directions and hence two resets and separate clocks for each direction, while i2s2 only provides one reset. This was so far named just "m" which isn't part of the binding. The clock-names the controller uses all end in "tx", so use the matching "tx-m" reset-name for the i2s controller. Fixes: 755f37010f3e ("arm64: dts: rockchip: RK356x: Add I2S2 device node") Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)