| Message ID | 20240227232531.218159-3-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SoC identification for Renesas RZ/V2H SoC | expand |
On 28/02/2024 00:25, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Add DT binding documentation for System Controller (SYS) found on > RZ/V2H(P) ("R9A09G057") SoC's. > > SYS block contains the SYS_LSI_DEVID register which can be used to > retrieve SoC version information. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > v1 -> v2 > - Dropped extal_clk node from example > - Replaced RZ/V2H{P} -> RZ/V2H(P) > - Dropped description for clocks & resets properties > - used <cpg 1> for clocks in example node > --- > .../soc/renesas/renesas,r9a09g057-sys.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > new file mode 100644 > index 000000000000..72bf8e733dcd > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2H(P) System Controller (SYS) > + > +maintainers: > + - Geert Uytterhoeven <geert+renesas@glider.be> > + > +description: You need | to preserve formatting With this: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, Thank you for the review. On Wed, Feb 28, 2024 at 7:49 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 28/02/2024 00:25, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Add DT binding documentation for System Controller (SYS) found on > > RZ/V2H(P) ("R9A09G057") SoC's. > > > > SYS block contains the SYS_LSI_DEVID register which can be used to > > retrieve SoC version information. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > --- > > v1 -> v2 > > - Dropped extal_clk node from example > > - Replaced RZ/V2H{P} -> RZ/V2H(P) > > - Dropped description for clocks & resets properties > > - used <cpg 1> for clocks in example node > > --- > > .../soc/renesas/renesas,r9a09g057-sys.yaml | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > new file mode 100644 > > index 000000000000..72bf8e733dcd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas RZ/V2H(P) System Controller (SYS) > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@glider.be> > > + > > +description: > > You need | to preserve formatting > Sure I will add "|". On that note some bindings have "|+" and some "|" what is the preferred one? Cheers, Prabhakar
On Wed, Feb 28, 2024 at 09:43:22AM +0000, Lad, Prabhakar wrote: > Sure I will add "|". On that note some bindings have "|+" and some "|" > what is the preferred one? I don't think the + should be used anywhere, it preserves all newlines at the end of a block of test. Maybe there's some specific instances, but in general I don't see a reason to use it.
Hi Conor, On Wed, Feb 28, 2024 at 11:16 AM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Feb 28, 2024 at 09:43:22AM +0000, Lad, Prabhakar wrote: > > > Sure I will add "|". On that note some bindings have "|+" and some "|" > > what is the preferred one? > > I don't think the + should be used anywhere, it preserves all newlines > at the end of a block of test. Maybe there's some specific instances, > but in general I don't see a reason to use it. > Thanks for the clarification. Cheers, Prabhakar
On Wed, Feb 28, 2024 at 12:26 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Add DT binding documentation for System Controller (SYS) found on > RZ/V2H(P) ("R9A09G057") SoC's. > > SYS block contains the SYS_LSI_DEVID register which can be used to > retrieve SoC version information. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > v1 -> v2 > - Dropped extal_clk node from example > - Replaced RZ/V2H{P} -> RZ/V2H(P) > - Dropped description for clocks & resets properties > - used <cpg 1> for clocks in example node Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.10, ... > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2H(P) System Controller (SYS) > + > +maintainers: > + - Geert Uytterhoeven <geert+renesas@glider.be> > + > +description: with "|" added. Gr{oetje,eeting}s, Geert
On Wed, Feb 28, 2024 at 11:34 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Feb 28, 2024 at 12:26 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Add DT binding documentation for System Controller (SYS) found on > > RZ/V2H(P) ("R9A09G057") SoC's. > > > > SYS block contains the SYS_LSI_DEVID register which can be used to > > retrieve SoC version information. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > --- > > v1 -> v2 > > - Dropped extal_clk node from example > > - Replaced RZ/V2H{P} -> RZ/V2H(P) > > - Dropped description for clocks & resets properties > > - used <cpg 1> for clocks in example node > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.10, ... > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas RZ/V2H(P) System Controller (SYS) > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@glider.be> > > + > > +description: > > with "|" added. > Thank you Geert for taking care of this. Cheers, Prabhakar
On 28/02/2024 10:43, Lad, Prabhakar wrote: >>> +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Renesas RZ/V2H(P) System Controller (SYS) >>> + >>> +maintainers: >>> + - Geert Uytterhoeven <geert+renesas@glider.be> >>> + >>> +description: >> >> You need | to preserve formatting >> > Sure I will add "|". On that note some bindings have "|+" and some "|" > what is the preferred one? Just | Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml new file mode 100644 index 000000000000..72bf8e733dcd --- /dev/null +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RZ/V2H(P) System Controller (SYS) + +maintainers: + - Geert Uytterhoeven <geert+renesas@glider.be> + +description: + The RZ/V2H(P) SYS (System Controller) controls the overall + configuration of the LSI and supports the following functions, + - Trust zone control + - Extend access by specific masters to address beyond 4GB space + - GBETH configuration + - Control of settings and states of SRAM/PCIe/CM33/CA55/CR8/xSPI/ADC/TSU + - LSI version + - WDT stop control + - General registers + +properties: + compatible: + const: renesas,r9a09g057-sys + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - resets + +additionalProperties: false + +examples: + - | + sys: system-controller@10430000 { + compatible = "renesas,r9a09g057-sys"; + reg = <0x10430000 0x10000>; + clocks = <&cpg 1>; + resets = <&cpg 1>; + };