From patchwork Wed Feb 28 11:37:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13575302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FB08C5478C for ; Wed, 28 Feb 2024 11:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=CYB0PK9Ci88cEqgHH+E3IQE9mi3tnIls0tbRKYr2vkI=; b=izsbF6VISW7tkY VEkIsrMnPG9HZ1lDY1spBGmXftkDl0l2zXDjLiq6dlsX+ZAcyYz5UO+BGIN8mL2YkwbmcF4QHHCfx 0M+5n0hS8ukVAMCO2WG1YX108Btsl/9/rKv8CyS0LbMY2wl9p7uFrbzBuY/DWheKg3Tna6dt9lDdV mD2DlWb3G4op42n/6Jd8kKuod96hRvQ/gg5zdqo7GUQBp7oiAR5BaR+ZUirMOdd8C2Mp8zQo92vR5 5B03MsakJzuUEBKnjJGSzY8LPVz5JQ2Ru9eJpauhwzO3Azi++r41e0ECH/tkTPnUH64/xGbHR8jhg bScmgFHnJPj+ggftMzUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfIJv-000000093nV-25WC; Wed, 28 Feb 2024 11:41:55 +0000 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfIFv-000000092c7-44em for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 11:37:50 +0000 Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7c785dda899so243323839f.2 for ; Wed, 28 Feb 2024 03:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709120266; x=1709725066; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hFtrXUgWnMJ9NQ2PU+2dtB8bMmOfzlQTR6EQYNPIXm0=; b=lrksQsemhAd9/otgiphCREyiXmkzeswxPg7MWL1IK4QatPJPe/76TaHurVwAX6iwfV IhZayMWBPqxSyutRfM8g9DJeZzGPTvNum+oSohLFSGDOih+ZsrgNj93aF/YDiJh/DkSi 4oymDaDyahi8iGRM1CXZ20ExgsUPIhEREVRDi6aHnqGMt8IF8JVTUMwhgxHpJzDEtSn7 r+gQ2QbD+GGXhdKTSdvUyZN/c/R93NrT0Rh9RzOMNznbwE37o9kVMb1srFR2BvdwxwRT kD9Zo2pEMaB7zkXF/zV69ApkPR1D9PYc+kJ6Tjo5KMQDS1ytm0jjgDfHQkLyChP30ipS Pz9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709120266; x=1709725066; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hFtrXUgWnMJ9NQ2PU+2dtB8bMmOfzlQTR6EQYNPIXm0=; b=HurHNuVgB5YPrD3D4dqwIJ3d7I3cScMKvnV7i77E6yLT0zP4sHboeLEEWKqU21WOce Zm4wuQ8ZAm8daVm75+0r+pQ5Ba3+OyT70aTvCyT2ZTxaGzZ0LsRlNLhlOq6IACUUu2jK z03nYArebAjt/fw9lgi5Ijnkb/RJ0LQRnE7bsJkl14GL1vqEGU5kYk16AWdpgtn2i7JN L+h86XU5jE2E2230MiLqyws0LZcxq+LqnKmeMdWYOALohnSGgQ5XOGsfsMUHjYHmN8sU NLoTSD3FN47IGo4D/SnWF5CJzaElCcKgpmlQRQC7xiF49IjkxSb9fHM6Gw0Cx84HRBHY Ww6A== X-Forwarded-Encrypted: i=1; AJvYcCUyZBYMjg9WzIcKVF3offAyrJqqCfwHElX6kgOVTDLOHscz/T2pACWZpKk4K2KT7HDuzQDMs9sSaubLBTdlF7NlOvCvB37tb3//ciSiVGoJ+QM7VOo= X-Gm-Message-State: AOJu0YyOxGofbNnJ/aSZVmqHhqrQcwvIxbyZgh4hvPP6rjLHMSxJt9xx Qea/oeFmJq9gNJpXEUTSXtLcf5YuKa90XS96EG6oTeYbSUcX0B6J X-Google-Smtp-Source: AGHT+IEwYOiAlwhhDwfp6MFMf8Kh9Xrgrs548zAUc51dykwi25IhwwwaKGbQtiBKAvrlGS0wowxSjQ== X-Received: by 2002:a5e:8f01:0:b0:7c7:fc3e:6f1b with SMTP id c1-20020a5e8f01000000b007c7fc3e6f1bmr967586iok.7.1709120266374; Wed, 28 Feb 2024 03:37:46 -0800 (PST) Received: from aford-System-Version.lan ([2601:447:d002:5be:abe6:89f4:1061:8343]) by smtp.gmail.com with ESMTPSA id k6-20020a02c646000000b004747d876aefsm1833147jan.6.2024.02.28.03.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 03:37:45 -0800 (PST) From: Adam Ford To: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Adam Ford , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins Date: Wed, 28 Feb 2024 05:37:35 -0600 Message-ID: <20240228113737.43434-1-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_033748_030596_1917452D X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The IRQ registration currently assumes that the GPIO is dedicated to it, but that may not necessarily be the case. If the board has another device sharing the IRQ, it won't be registered and the hot-plug detect fails. This is easily fixed by add the IRQF_SHARED flag. Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b5518ff97165..21f08b2ae265 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1318,7 +1318,8 @@ static int adv7511_probe(struct i2c_client *i2c) ret = devm_request_threaded_irq(dev, i2c->irq, NULL, adv7511_irq_handler, - IRQF_ONESHOT, dev_name(dev), + IRQF_ONESHOT | IRQF_SHARED, + dev_name(dev), adv7511); if (ret) goto err_unregister_audio;