From patchwork Wed Feb 28 12:38:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13575427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F7EC5478C for ; Wed, 28 Feb 2024 12:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zLE1jrs8HTiyPgwDbA3WL7BaxIZLa+42S1eCeh0jtjY=; b=z0aZmVx2pdpJv0 oLVUTt0UGKQuyZxOhdvpfi0mu9Pz6R3AzyJGRgPMMxHJpdOO1Nf9v5LLnBsjx5o9H/386ztVD6FAg BCmcTTfeIIBEKAC3VyL7BxSPZfZq3pmLr93ozr7beP9evIVdrx7+Wp1xymqSwxAGMHD0TrzTer7+L Y3TICMFqpIqJV71wgi08XnEyNwWYOjYzcsq7cdBzXF0TPsX5r3SaxPa3ip0hFK19sMk6sK9ZyLqZ8 zwqcvRazEMLcZppvjY68fINGNgXt+EB7iDxNg967qCip9xrv0P0tXn1mkBJgk2oIIPgw1HZ83Cj+Y tlf+0/mL67HNITaiJCSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfJDV-00000009H4S-0S3B; Wed, 28 Feb 2024 12:39:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfJDS-00000009H40-2YNR for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 12:39:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 43E0E61847; Wed, 28 Feb 2024 12:39:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7AF7C433C7; Wed, 28 Feb 2024 12:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709123956; bh=bseaJOEK/c5MecAUNtAoKFET6o0lT4gHWnFIu3pMeyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FNDwjU+FDQa6E87E/XZD7Dm1GjuTunKtbCAKCndFMrCZ7ct0/1X0h5SFEd8hT5ao1 Vf2FteZzC0JOT4LuqurAkB2SENRTOwebd1ajdMr70TK2q5xNWxGn5oBsufmFm3hbt9 QjK3KJQ/8Dgm/2jynSGwQG6qbhlKsx26E1Eh8aLiQIZ41rJQAaUp2R/mB63XQh+p61 UP+1nJ/9QpbJQzXm6ACkG7bg7kmNKiZ9lzLQCuXaT912hIDlaKn2YMyNEDIcDw1Rj2 OW7FJI4xHV6PqCadSPY7tNauGcQ+Ti7/OVWuYx+MJx0uQ7ME174dXwleYrvxTjjOFK 9UxRTH3LZHvsg== From: Arnd Bergmann To: Frederic Weisbecker , Thomas Gleixner , Ingo Molnar Cc: Arnd Bergmann , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT Date: Wed, 28 Feb 2024 13:38:42 +0100 Message-Id: <20240228123850.3499024-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228123850.3499024-1-arnd@kernel.org> References: <20240228123850.3499024-1-arnd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_043918_715084_CC945B3F X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann ARCH_BCM_MOBILE is the only platform that selects CONFIG_TICK_ONESHOT, the others stopped 12 years ago in commit 98fab064d321 ("ARM: Remove unnecessary selection of TICK_ONESHOT"). This inconsistency caused a build regression after an otherwise correct change to the timers subsystem: kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying' 1599 | void tick_sched_timer_dying(int cpu) | ^ kernel/time/tick-sched.h:111:20: note: previous definition is here 111 | static inline void tick_sched_timer_dying(int cpu) { } Drop this dead select. Fixes: 3aedb7fcd88a ("tick/sched: Remove useless oneshot ifdeffery") Signed-off-by: Arnd Bergmann --- arch/arm/mach-bcm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 8df4b23e2699..ed6415e7e3a4 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -93,7 +93,6 @@ config ARCH_BCM_MOBILE select ARM_ERRATA_775420 select ARM_GIC select GPIO_BCM_KONA - select TICK_ONESHOT select HAVE_ARM_ARCH_TIMER select PINCTRL select ARCH_BCM_MOBILE_SMP if SMP