diff mbox series

[2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

Message ID 20240229023522.15870-3-jason-jh.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add GAMMA 12-bit LUT support for MT8188 | expand

Commit Message

Jason-JH.Lin Feb. 29, 2024, 2:35 a.m. UTC
The gamma LUT setting of MT8188 and MT8195 are the same, so we create
a one of items for MT8188 to reuse the driver data settings of MT8195.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Feb. 29, 2024, 8:27 a.m. UTC | #1
On 29/02/2024 03:35, Jason-JH.Lin wrote:
> The gamma LUT setting of MT8188 and MT8195 are the same, so we create
> a one of items for MT8188 to reuse the driver data settings of MT8195.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index 3e6cb8f48bcc..90c454eea06f 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -29,6 +29,10 @@ properties:
>            - enum:
>                - mediatek,mt6795-disp-gamma
>            - const: mediatek,mt8173-disp-gamma
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-disp-gamma
> +          - const: mediatek,mt8195-disp-gamma
>        - items:
>            - enum:
>                - mediatek,mt8186-disp-gamma

Please keep this ordered by fallback compatible, so your list with 8195
fallback should go below the list here.

Best regards,
Krzysztof
AngeloGioacchino Del Regno Feb. 29, 2024, 8:47 a.m. UTC | #2
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> The gamma LUT setting of MT8188 and MT8195 are the same, so we create
> a one of items for MT8188 to reuse the driver data settings of MT8195.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Jason-JH.Lin Feb. 29, 2024, 9:13 a.m. UTC | #3
Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-02-29 at 09:27 +0100, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 29/02/2024 03:35, Jason-JH.Lin wrote:
> > The gamma LUT setting of MT8188 and MT8195 are the same, so we
> create
> > a one of items for MT8188 to reuse the driver data settings of
> MT8195.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4
> ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > index 3e6cb8f48bcc..90c454eea06f 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > @@ -29,6 +29,10 @@ properties:
> >            - enum:
> >                - mediatek,mt6795-disp-gamma
> >            - const: mediatek,mt8173-disp-gamma
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-disp-gamma
> > +          - const: mediatek,mt8195-disp-gamma
> >        - items:
> >            - enum:
> >                - mediatek,mt8186-disp-gamma
> 
> Please keep this ordered by fallback compatible, so your list with
> 8195
> fallback should go below the list here.
> 
OK, I'll move it here.

Regards,
Jason-JH.Lin

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
index 3e6cb8f48bcc..90c454eea06f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
@@ -29,6 +29,10 @@  properties:
           - enum:
               - mediatek,mt6795-disp-gamma
           - const: mediatek,mt8173-disp-gamma
+      - items:
+          - enum:
+              - mediatek,mt8188-disp-gamma
+          - const: mediatek,mt8195-disp-gamma
       - items:
           - enum:
               - mediatek,mt8186-disp-gamma