diff mbox series

staging: bcm2835-audio: add terminating new line to Kconifg

Message ID 20240311100920.1271545-1-ppandit@redhat.com (mailing list archive)
State New, archived
Headers show
Series staging: bcm2835-audio: add terminating new line to Kconifg | expand

Commit Message

Prasad Pandit March 11, 2024, 10:09 a.m. UTC 
From: Prasad Pandit <pjp@fedoraproject.org>

Add terminating new line to the Kconfig file.

Fixes: 8848e22ca385 ("staging: bcm2835-audio: fully describe config
symbol")

Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
 drivers/staging/vc04_services/bcm2835-audio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli March 12, 2024, 1:53 p.m. UTC | #1 
On 3/11/2024 3:09 AM, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
> 
> Add terminating new line to the Kconfig file.
> 
> Fixes: 8848e22ca385 ("staging: bcm2835-audio: fully describe config
> symbol")

The Fixes: tag is not required here because this is not fixing a 
functional bug that will impact users. Also, the Fixes: tag does not 
require adding an extra newline.

> 
> Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>

It does not look like you copied all of the maintainers for this file:

  ./scripts/get_maintainer.pl -f 
drivers/staging/vc04_services/bcm2835-audio/Kconfig
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING 
SUBSYSTEM)
Florian Fainelli <florian.fainelli@broadcom.com> (maintainer:BROADCOM 
BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
Ray Jui <rjui@broadcom.com> (maintainer:BROADCOM 
BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
Scott Branden <sbranden@broadcom.com> (maintainer:BROADCOM 
BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
Broadcom internal kernel review list 
<bcm-kernel-feedback-list@broadcom.com> (reviewer:BROADCOM 
BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM)
linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM 
BCM2711/BCM2835 ARM ARCHITECTURE)
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM 
BCM2711/BCM2835 ARM ARCHITECTURE)
linux-kernel@vger.kernel.org (open list)

Please re-submit with all of those recipients copied and without the 
Fixes: tag.

Thank you
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
index 7f22f6c85067..7fbb29d3c34d 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig
+++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
@@ -8,4 +8,4 @@  config SND_BCM2835
 	  Say Y or M if you want to support BCM2835 built in audio.
 	  This driver handles both 3.5mm and HDMI audio, by leveraging
 	  the VCHIQ messaging interface between the kernel and the firmware
-	  running on VideoCore.
\ No newline at end of file
+	  running on VideoCore.