Message ID | 20240313091259.1413854-1-ppandit@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v2] staging: bcm2835-audio: add terminating new line to Kconifg | expand |
Normally, I would let Greg decide to notice or ignore the typo in the subject but he's on vacation... s/Kconifg/Kconfig/ On Wed, Mar 13, 2024 at 02:42:59PM +0530, Prasad Pandit wrote: > From: Prasad Pandit <pjp@fedoraproject.org> > > Add terminating new line to the Kconfig file. Why does this make a difference? Is it just because it's annoying to cat a file that doesn't have a newline at the end? I checked, and it's not a checkpatch warning. Perhaps it should be though. KTODO: make checkpatch.pl warn about files that don't end in a newline Since you're resending anyway could you add that information to the commit message? Something like: "Add terminating new line to the Kconfig file. Otherwise it's annoying to cat files that don't have a newline. #PetPeeve". Just fix the subject and add a line to the commit message and I'll ack the patch. regards, dan carpenter
Hi, On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@linaro.org> wrote: > Why does this make a difference? Is it just because it's annoying to > cat a file that doesn't have a newline at the end? * It's not just #PetPeeve. I'm trying to fix parsing errors reported by the config-kernel tool[1], so that users can view all CONFIG attributes without errors. > I checked, and it's not a checkpatch warning. Perhaps it should be though. > KTODO: make checkpatch.pl warn about files that don't end in a newline * I'll take a look at checkpatch.pl. > subject but he's on vacation... s/Kconifg/Kconfig/ > Just fix the subject and add a line to the commit message and I'll ack the patch. * Okay, will send a revised patch. Thank you. --- - Prasad [1] https://github.com/pjps/config-kernel
On Wed, Mar 13, 2024 at 04:44:09PM +0530, Prasad Pandit wrote: > Hi, > > On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@linaro.org> wrote: > > Why does this make a difference? Is it just because it's annoying to > > cat a file that doesn't have a newline at the end? > > * It's not just #PetPeeve. I'm trying to fix parsing errors reported > by the config-kernel tool[1], so that users can view all CONFIG > attributes without errors. Huh. The seems like a very nice program. I've wanted a way to enable config items from command line for a long time. I wasn't able to get it enable the CONFIG_NO_HZ_FULL. ~/config-kernel/configk -e NO_HZ_FULL -c .config . I'm going Ack your patch because adding a newline is the correct thing but you should probably also change configk to handle that. > > > I checked, and it's not a checkpatch warning. Perhaps it should be though. > > KTODO: make checkpatch.pl warn about files that don't end in a newline > > * I'll take a look at checkpatch.pl. It's not required. The KTODO is just a shared todo list and anyone can add stuff to todo list or do it, but it's not mandatory at all. regards, dan carpenter
Hello Dan, On Wed, 13 Mar 2024 at 17:24, Dan Carpenter <dan.carpenter@linaro.org> wrote: > I wasn't able to get it to enable the CONFIG_NO_HZ_FULL. * CONFIG_ prefix is not required. > ~/config-kernel/configk -e NO_HZ_FULL -c .config . * This command works. It writes informatory logs to stderr. It helps to redirect stderr to a log file. Enable option: NO_HZ_FULL NO_HZ_COMMON TICK_ONESHOT RCU_NOCB_CPU VIRT_CPU_ACCOUNTING_GEN VIRT_CPU_ACCOUNTING CONTEXT_TRACKING_USER CONTEXT_TRACKING IRQ_WORK CPU_ISOLATION * To see enable/disable/toggle options in action, a command below (without -c .config) could make it easier perhaps. $ ~/config-kernel/configk -e NO_HZ_FULL=[y/n/m] <linux-directory> | less -r > I'm going Ack your patch because adding a newline is the correct thing > but you should probably also change configk to handle that. * ie. Handle files not terminating with a newline? There are not as many such files. Besides I agree having files terminate with a newline is good. It makes all lines/records of consistent format, otherwise the very last line/record becomes a special case. Thank you. --- - Prasad
diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kconfig index 7f22f6c85067..7fbb29d3c34d 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig +++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig @@ -8,4 +8,4 @@ config SND_BCM2835 Say Y or M if you want to support BCM2835 built in audio. This driver handles both 3.5mm and HDMI audio, by leveraging the VCHIQ messaging interface between the kernel and the firmware - running on VideoCore. \ No newline at end of file + running on VideoCore.