| Message ID | 20240327134115.424846-2-linkmauve@linkmauve.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable JPEG encoding on rk3588 | expand |
On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > According to the TRM[1], there is also the VEPU580 encoder which > supports H.264 and H.265, and various VDPU* decoders, of which only the > VDPU981 is currently supported. This patch describes only the VEPU121. > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 9d90d8d0565a..4c6cb21da041 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -15,8 +15,12 @@ description: > > properties: > compatible: > - enum: > - - rockchip,rk3568-vepu > + oneOf: > + - const: rockchip,rk3568-vepu > + - items: > + - enum: > + - rockchip,rk3588-vepu121 > + - const: rockchip,rk3568-vepu > > reg: > maxItems: 1 > -- > 2.44.0 >
Hi, On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > According to the TRM[1], there is also the VEPU580 encoder which > supports H.264 and H.265, and various VDPU* decoders, of which only the > VDPU981 is currently supported. This patch describes only the VEPU121. > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 9d90d8d0565a..4c6cb21da041 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -15,8 +15,12 @@ description: > > properties: > compatible: > - enum: > - - rockchip,rk3568-vepu > + oneOf: > + - const: rockchip,rk3568-vepu > + - items: > + - enum: > + - rockchip,rk3588-vepu121 > + - const: rockchip,rk3568-vepu > > reg: > maxItems: 1 > -- > 2.44.0 >
Le mercredi 27 mars 2024 à 17:23 +0000, Conor Dooley a écrit : > On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote: > > This encoder-only device is present four times on this SoC, and should > > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > > encoding). > > > > According to the TRM[1], there is also the VEPU580 encoder which > > supports H.264 and H.265, and various VDPU* decoders, of which only the > > VDPU981 is currently supported. This patch describes only the VEPU121. > > > > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet > > > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> I'd like to prevent this change until we fix the driver. It should not expose 1 video device per core, it should instead do schedule around these cores. Nicolas > > Thanks, > Conor. > > > --- > > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > index 9d90d8d0565a..4c6cb21da041 100644 > > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > > @@ -15,8 +15,12 @@ description: > > > > properties: > > compatible: > > - enum: > > - - rockchip,rk3568-vepu > > + oneOf: > > + - const: rockchip,rk3568-vepu > > + - items: > > + - enum: > > + - rockchip,rk3588-vepu121 > > + - const: rockchip,rk3568-vepu > > > > reg: > > maxItems: 1 > > -- > > 2.44.0 > >
diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml index 9d90d8d0565a..4c6cb21da041 100644 --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml @@ -15,8 +15,12 @@ description: properties: compatible: - enum: - - rockchip,rk3568-vepu + oneOf: + - const: rockchip,rk3568-vepu + - items: + - enum: + - rockchip,rk3588-vepu121 + - const: rockchip,rk3568-vepu reg: maxItems: 1
This encoder-only device is present four times on this SoC, and should support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 encoding). According to the TRM[1], there is also the VEPU580 encoder which supports H.264 and H.265, and various VDPU* decoders, of which only the VDPU981 is currently supported. This patch describes only the VEPU121. [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> --- .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)