From patchwork Mon Apr 1 22:25:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613078 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76711CD1288 for ; Mon, 1 Apr 2024 22:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3Unpd9+NCeWs5EvcfQBOu0QpmgENZyAGr5bjQJUgMZw=; b=Qohq0LXdBhF5DO38lI3hZlHZFI Qt9lwk4U3xZjDGYgGDqA8SPb/iHNAf+QkJ5HTi5mnE8PG7++u5askdkmkyaU4hoS0lTK9D1G0p2CM 211kXfJ2sAOdjzLDFK6Xq64M6NaWwXtvPcGK2FT0KhCJIeS8laZa+9JKFs16lTcryqFHSugHfv2iC su5VwCFCbMo3/2umPLH0uzNobKUi7cRJLbKCzqgp4dwg4tPjjvt1GPKUmC4Edg/vRDov0oWbSmizp 0ajMaTLfLbCFD/+K6nhkW4IyMRnk+gnpnG/mZZBLQmHUqhTssXPBprAyz/jmdt0jm8hKIRcsgrb5n lqQ1hqNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQL8-0000000925y-3PxY; Mon, 01 Apr 2024 22:41:18 +0000 Received: from mail-am6eur05on20701.outbound.protection.outlook.com ([2a01:111:f403:2612::701] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQL6-00000009241-2SVJ for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:41:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8UopdBYQsXS8w2/0xFZ9BBDmYW4JBbF+i33Hn9n92a0wQ3cPbgyH7RJ1aKEo0Ek/Kc0/6Ct4pCSBt3csoGHE473+z/+DTlaykTd8dV14Kp5LATRt5NSaSwmWfDA0Ly5ExfJltIxlcg9Pj8dFCI2IHrHyW3Ggck6Mm5UOZFhC4eGPLCMu1+h5KyAn5+hMLUnbpjRyJrW8w2UEw8mihKBElPNZGeNe0ndPkehP7XqahG24iAB2Nd/6BWz3FmVzgVL9ASpYSX7cqxFC6nVh20HMeFHtkT01nqO4k91HL7Gin0Bc71TRqhpl0kUwEseB7mrENJZPv25kQnhubjbn7lBlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=GR2OoS1ddW5gH2D9XW0Vi2VNyxCZCW9+HWYLMpXecBM6IETsmqhAybgmbzKIhnbLBRiqqW7DytJik4tTnkzdvnTkERoFwkMb/YfByDRCTaOtlJq6vE4mYreiH8dWiW549wZai/s4lzFiUoZV0hTs0dYk6RboPawFOPWCCNuLr+zoP+NVVHQmvMDtqy2IUsrh/vIJvi3ZUbW5QBHmI7M+hlYxeMplk8kUpNcnn3YH2xuSY13gsy1pvEzH2wMNfgpu7xsYQddxmUGU1I8uK9ZO/fEiYmayaujQqdt99j1trEOcW/LaheX8MOOHWTDTsZrsPzNHcvnz4l+f4PybgKcaHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=CRIAky0Ovh9T+VmQa7+abDuBC84tyztsOzoCWMkFps9K+9O4TP0WUctvgKGCjdAz3nf6GipA7ET8DhBZmJXCdm71IzK1+GYhTDjBAZIEPKGHBeHYXRLZMDWIj2MCIcG5EqkszrxgKWcbn/oSJLy7lIjo+57IXbummYUE+ogRjv8= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:52 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:52 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:06 -0400 Subject: [PATCH 4/7] arm64: dts: imx8-ss-dma: fix pwm lpcg indices Message-Id: <20240401-dts_fix-v1-4-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1745; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=fdsoDcgdp2uhQaS8/tOFn5VfeICbpQvKk3TSdwKDGp4=; b=Hh3oHxBHwLYgBiYlmxkonIQ2s0FE32klh2UftURC2duBM/QoEZKeS/irbACu2GxSeH9yqGfw0 2bTkFJb5AfXBRpA6yxmOrZN7SZZ1kjxCf0hOkK3LWlYp9nrWlz5CTLI X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fye7lKqJHORFe6N9XfLjlIOVK9GX7EkUHar5+h4AzMCQ1Fn8yrtAW2XtP0kIkYS1Sdq8wBAqo7wqAZuYsRcd2FQWQya9oYXmbpqiKgfi8+n2RdTFK/psnbVG1lR3mXPt7Wls5yiJ+jn4y7lIyAS+1CeCFr3dFGAPrwSU8EGk8LuRQt0vqpGkUcUlPo3IuSAzV4WGwXdh9YBWAV5qCjVsVPyfljincGdLmGF6qdEktdAc84yJoMadUD5onyOLj/YBB/xHfswnslELGbasKsRjYQ6K+lnhPRdB3gAtjru9TM4vKvh+fX1ASfs9XWqjK2oOdqXQ4dqWs4zDkdRzl2tPTJJWG9rctoNuiPUabdlP1nIzqdlmXsEpfu00EoCZXiRaHzWS/w7ko6O2bvkNdlT0rkUMuMSFIyLjAlk5K576lk6cIvYPuCOhYJZI0bclXrfpjVo87ha/Qw3pYJJdo7M5r/NF+fD1sui3KGgzgf4DNZCXN6Xfx5Z3ZHv4I9PC9ckOzGYjUAhfJo435x+kPMbxKkcYy1/bPy8WV5nEmnbxP6TVuJRH81kdwpTTvr4nhkJggpnMyTPqyWG0Cm0YZuqLIcLGr8mVfNTyJ7eiEt50vEfHZQ0NUbyqtkStWgyKfAgTk27Jqq62yJoXx3pbjsPyma44sBY+ButjVTFJjtP20GnHdmBp5SI5rcVTF0n4uPFN7KNLwDBAK1d4XxtLtdVqbHgXDumVy+bjoezR34zdgEk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Hgv2szfdn6mViSp2iJOBDerEt6OF?= =?utf-8?q?vj+xlVUzcu61dtttB0+gmoxLrSPvczIYU19uE8lpTF0OwPg9LV6gTi6beGCZZROE2?= =?utf-8?q?2IqXZemoPUWnynGyV1T7PsozRj8Qmt9oKPJpN3a0V1c1IfeJuDxBOAxQgaOPA1lpH?= =?utf-8?q?f89Ne6MfDHOI7VM9fpOT+AD//o8P8XxdJZ3x3tABCEpfnQZjL9fI8YC7OgfiMPmUq?= =?utf-8?q?uQ/vV3pJr+6iNMHAJatozQfVEIhDRca9nqf/9fzVfzlu0GQz6WPLSDVH6AwxqBY6J?= =?utf-8?q?5FDbpPFrNJm5Na2AzQvd6QU3HjXT1ONEX2E3SjSold8ko4RbcgWU4zCjJZssGbdmH?= =?utf-8?q?RG9iGBMaosWtyoxGhiG0Tg5lMnM4X4YamGTwNXRZZMeSYBib0ROMQAWHF+W3s6JQJ?= =?utf-8?q?7yfeFKRevcSFd7agc1RFgP3IBRqNnjV4qEpJULV574J9wK3rtXykCpUEjSjlkXJh9?= =?utf-8?q?i8MPb6RMGsXFGxaUmWuFFxn4tYAjwz8iCC02nJpdT2DnLrhpY7Wzo/SYD32KkRzhN?= =?utf-8?q?tP4QTw1CExS9973604hfpy5p1L4PWURxgDwrzlmR4qtkUZGWwHyZuJvskhUA90GM+?= =?utf-8?q?kGmjNzz3NmaKTOOvba66gvUTBH60ZkJxD+5VmxtBrt34+It2KGsRFXPTFxYfNBxG3?= =?utf-8?q?P7ab8b3arIcCRH3Xh75PEYcXwu+Ep9Q+5zg4OgWxaJSBwwZuiRPSCnatThEmWu74z?= =?utf-8?q?P7ccTE4I5WjovdVzbekIrobEh6+6JEDNIJlPPbWpnqcvGErA511j6V3BKXHgg6l2q?= =?utf-8?q?mLf+/IuTXSVwkXkaM3HWESes0Sdzt8KLDUjTmTERLA6RsZvo0IciodAlMX3dOYrrD?= =?utf-8?q?FQPccrHphdCX0psXCdOvkpdwiRNuyxDba0r6I97sMlyzd+NrvEhyu7bw9V+XNYNTx?= =?utf-8?q?vISCCLUyc2jIOO1KsksE3IC8GRfeKHL6Jxy8LfTZA+z/oEsjQj4H/IEAUYLOoc3OT?= =?utf-8?q?diWJonv+Umy1UOxJ29wtIml+MnGAwzPQJCFAf4T9fJF6YViyggSZC8Si8iK8NsoYm?= =?utf-8?q?jyY1yOQgSwLwIxjy/ZKSY54ExLzHKjA1Zyj/1N+5es+4m2zTm3FgAVyxBS6TIaqRZ?= =?utf-8?q?Gl8f4LlcMx/W/PTStC6eq1HwemHw5EcULhesHrBKRG/bzewmdB9jtPR2jEkwwbV4p?= =?utf-8?q?2DK/dMKa/khjAJDu9A1nAy+U64nEgN/s/x22fqJejYI0d5+n/VHdyLEhgxWmgkCmu?= =?utf-8?q?ek9ehgYpMeMICcym9E0Axai1r9tNzzLVJLEWGkXTLiHckujjclMtyVEn3Rjg36ro+?= =?utf-8?q?KcjkHEBls1MmP7K+N683LMz5Tbul4XDdkPQjmVvnr3Y9+jHYOgNfPV73GIBvINpXP?= =?utf-8?q?un7mEDgZ+0Lj0bOcRL9MnEnXVnYLj9ZuhzQifp21ObNlCutJKMnI1PVu/JRTQdrlB?= =?utf-8?q?wuWoF6Mewsa6AiaVAEtFxyorQ8UV9H97eCO/n1G1A3I6WOY1G12ZJsWM5pO15O5Rr?= =?utf-8?q?cFhQpRN9Lo+nN9IlN02qW+C5qM7+XBDwvEAUWUxSMw8lr+2CV3+MpQ0w=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10a7e5bd-1707-4ca6-bf32-08dc529ab078 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:51.9808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UsRmB/Wna8OXWVmxaQrB4n1JaqRTbZDbVpLJ6rPIWUz7CV7YODLhuwUuFZHT1IZUiNShfGA9oJ6ZZ2snFmNXYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154116_701122_72B8B738 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org adma_pwm_lpcg: clock-controller@5a590000 { ... col1 col2 clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>; // 1 4 clock-indices = , ; ... }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. adma_pwm: pwm@5a190000 { ... clocks = <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>; ^^ ^^ Should be clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>, <&adma_pwm_lpcg IMX_LPCG_CLK_0>; }; Arg0 will be divided by 4 in lcpg driver, so pwm will get IMX_SC_PM_CLK_PER by <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>. Although function can work, code logic is wrong. Fix it by use correct indices. Cc: stable@vger.kernel.org Fixes: f1d6a6b991ef ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index a124d6598406d..d4637037ba1b6 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -144,8 +144,8 @@ adma_pwm: pwm@5a190000 { compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm"; reg = <0x5a190000 0x1000>; interrupts = ; - clocks = <&adma_pwm_lpcg 1>, - <&adma_pwm_lpcg 0>; + clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>, + <&adma_pwm_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>;