From patchwork Mon Apr 1 15:37:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612854 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C274ECD128D for ; Mon, 1 Apr 2024 15:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ujoDERPKpzMAM0MwchO4xF3yf3y/W6H3wv1gCTJaEE=; b=nvqb1ILoHzLIIr JdygP+qRUwkgf6omm8K5pNlK+yq7b/HNJcwEJjWTOIfJIAmKQSTbTl5qDRKvobHNT5eVqwV2V1uEI 4lWWHPkZSQYbxEa+FTdvipF/JOiBiYReGkGxxEP7y1NBZajfGBJRWmszekfCNaTDX49RCQ/dYKFFu sbmujWqEfmuGb8Htv1jeIhPPIS8FQAzEjSVXPqBi6vVsrz+NRhj3cULm98Un/WmS6KN1BsieiAcrR 8X0BBb54KJ3tp+VYuyqUje/RjQRZAqambSYOcjGRuTGpJkWR1UxhZIvJ/B/AB8fkCvp6tIUOaLyIH h06Lkge39/xRxGJNkZvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk7-00000008DEz-0LRA; Mon, 01 Apr 2024 15:38:39 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk5-00000008DDK-46sE for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Apr 2024 15:38:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=IJCsqArQ3YGdCuCDuTH+/jxUleXNfjHN49mfTD+G/zY=; b=Av2EoeideP/oqqFw4Myyr2YDZC 6zru0R6PZDKGV4EuDmCL4swyoTMkWgdW+WJBF1M3BUnekPsrYyvP9hMJBhSea/Qt2+VdTA9KxWdO7 +cU5gfmbgBltLr2GsdLS4WzSRHGt9AOwZ2aDOzdgY4xABhLIKktOXrbUdc4URoT1Rz4redPPf1XY1 wrLuSq0Hcos8wnhDtnJbXQrV8wrNTgJxE7AWMRyWVR6Bqlr1thbWx+83nJyBhnK2xd5aPqQHLO3Y0 QdskxFtt3iTZSMRM1v3vxe3iTl0KOwxlYpU0A2G9PVa/ewSA0qae7/U64p6t0UkLvAzSHbGunH16c SeSUYlXg==; Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk2-000000038q9-1e7d for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BEF1ACE0EB9; Mon, 1 Apr 2024 15:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 733B5C433A6; Mon, 1 Apr 2024 15:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985910; bh=aCit6vORDAYB870bYOiXT5ndGlqhSP/fqB0fbs8e4P8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nvCtQKXE8ZHNsVUuGOJRaM7sOvx5VVg+yyHmMZ9kkhIWh1IWHq5UKrBdigG6sks2X WLH60WjmwVHrb3BUQnmySGAHzuDBNG6Pl9bIFZDmc5H2D4XBenV68YNIk2y32z2lZQ DhI2or0xTlJXdD73Uv4/Rs4LlwzCz0dd/xjH185pmsBk90Zaw/+Eo7MYoDYmTUt4vY BI4gobZV/Jvhei8xhYYoAqK3AD/+JIL065ZlkUqaE6ohq+CLA3PGa8hDxjd83PJ/Pm N+rEAUUlPQS6ObspFYY6K5ztxZnAGboevD75NJQj/hlMTSjw/jWlTAW2mwzfvL0wC2 4jccThBFhXA1A== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Date: Mon, 1 Apr 2024 17:37:39 +0200 Message-Id: <20240401153740.123978-9-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_163834_965445_6CC71943 X-CRM114-Status: GOOD ( 10.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Without checking in datasheet, assume device has only one SPI NOR flash, so code was duplicated. Fixes dtc W=1 warnings: sparx5_pcb134_board.dtsi:277.10-281.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware --- .../boot/dts/microchip/sparx5_pcb134_board.dtsi | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index f165a409bc1d..dc7b59dfcb40 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -281,22 +281,6 @@ flash@0 { }; }; -&spi0 { - status = "okay"; - spi@0 { - compatible = "spi-mux"; - mux-controls = <&mux>; - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; /* CS0 */ - flash@9 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0x9>; /* SPI */ - }; - }; -}; - &sgpio0 { status = "okay"; microchip,sgpio-port-ranges = <8 15>;