| Message ID | 20240402193148.62323-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/9] arm64: dts: hisilicon: hip05: move non-MMIO node out of soc | expand |
On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: > Non-MMIO devices, which are BTW not really part of the SoC, should not > be within simple-bus, as reported by dtc W=1 warning: > > hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property > > Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know. Applied, thanks! [1/9] arm64: dts: hisilicon: hip05: move non-MMIO node out of soc https://git.kernel.org/krzk/linux-dt/c/8ff69c1d04c8f2381164c5f97781d9fe79f71761 [2/9] arm64: dts: hisilicon: hip05-d02: correct local-bus unit addresses https://git.kernel.org/krzk/linux-dt/c/4e0e9c0b311e599c78f63942256ccf03e5ebb0f5 [3/9] arm64: dts: hisilicon: hip06: move non-MMIO node out of soc https://git.kernel.org/krzk/linux-dt/c/2283b9afc1b43ec941c66665cdc86dd32f9c2295 [4/9] arm64: dts: hisilicon: hip06: correct unit addresses https://git.kernel.org/krzk/linux-dt/c/6c55978774fd66c720e20e1f88a2af7daaa382df [5/9] arm64: dts: hisilicon: hip07: move non-MMIO node out of soc https://git.kernel.org/krzk/linux-dt/c/5e607ec42116e0ecb387e2db79a662333f789fa2 [6/9] arm64: dts: hisilicon: hip07: correct unit addresses https://git.kernel.org/krzk/linux-dt/c/76dce22bc7ec9483ef37899a617f2dfde2a382c0 [7/9] arm64: dts: hisilicon: hi6220-hikey: add missing port@0 reg https://git.kernel.org/krzk/linux-dt/c/d6fcc43f764630863e3888d0b5c3ff4a09a4f094 [8/9] arm64: dts: hisilicon: hi6220-hikey: drop unit addresses from fixed regulators https://git.kernel.org/krzk/linux-dt/c/e6a91e9f20058629dca4f0c264de092049bd8e74 [9/9] arm64: dts: hisilicon: hi6220: correct tsensor unit addresses https://git.kernel.org/krzk/linux-dt/c/83d4c5e2a529e3eebde5b4d75e3ec0fe2fc92440 Best regards,
Hi Krzysztof, On 2024/4/24 14:54, Krzysztof Kozlowski wrote: > > On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: >> Non-MMIO devices, which are BTW not really part of the SoC, should not >> be within simple-bus, as reported by dtc W=1 warning: >> >> hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property >> >> > > Almost a month passed, no replies from maintainers about picking it up. Dunno, > looks abandoned, so let me grab this. If anyone else wants to pick it up, let > me know. > Sorry for the late reply! I am applying these patches which are in the following git repo. https://github.com/hisilicon/linux-hisi/tree/next/dt64 And it is fine to me to go through your git tree. Thanks! Best Regards, Wei > Applied, thanks! > > [1/9] arm64: dts: hisilicon: hip05: move non-MMIO node out of soc > https://git.kernel.org/krzk/linux-dt/c/8ff69c1d04c8f2381164c5f97781d9fe79f71761 > [2/9] arm64: dts: hisilicon: hip05-d02: correct local-bus unit addresses > https://git.kernel.org/krzk/linux-dt/c/4e0e9c0b311e599c78f63942256ccf03e5ebb0f5 > [3/9] arm64: dts: hisilicon: hip06: move non-MMIO node out of soc > https://git.kernel.org/krzk/linux-dt/c/2283b9afc1b43ec941c66665cdc86dd32f9c2295 > [4/9] arm64: dts: hisilicon: hip06: correct unit addresses > https://git.kernel.org/krzk/linux-dt/c/6c55978774fd66c720e20e1f88a2af7daaa382df > [5/9] arm64: dts: hisilicon: hip07: move non-MMIO node out of soc > https://git.kernel.org/krzk/linux-dt/c/5e607ec42116e0ecb387e2db79a662333f789fa2 > [6/9] arm64: dts: hisilicon: hip07: correct unit addresses > https://git.kernel.org/krzk/linux-dt/c/76dce22bc7ec9483ef37899a617f2dfde2a382c0 > [7/9] arm64: dts: hisilicon: hi6220-hikey: add missing port@0 reg > https://git.kernel.org/krzk/linux-dt/c/d6fcc43f764630863e3888d0b5c3ff4a09a4f094 > [8/9] arm64: dts: hisilicon: hi6220-hikey: drop unit addresses from fixed regulators > https://git.kernel.org/krzk/linux-dt/c/e6a91e9f20058629dca4f0c264de092049bd8e74 > [9/9] arm64: dts: hisilicon: hi6220: correct tsensor unit addresses > https://git.kernel.org/krzk/linux-dt/c/83d4c5e2a529e3eebde5b4d75e3ec0fe2fc92440 > > Best regards, >
On 24/04/2024 09:16, Wei Xu wrote: > Hi Krzysztof, > > On 2024/4/24 14:54, Krzysztof Kozlowski wrote: >> >> On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: >>> Non-MMIO devices, which are BTW not really part of the SoC, should not >>> be within simple-bus, as reported by dtc W=1 warning: >>> >>> hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property >>> >>> >> >> Almost a month passed, no replies from maintainers about picking it up. Dunno, >> looks abandoned, so let me grab this. If anyone else wants to pick it up, let >> me know. >> > > Sorry for the late reply! > I am applying these patches which are in the following git repo. > https://github.com/hisilicon/linux-hisi/tree/next/dt64 > > And it is fine to me to go through your git tree. > Thanks! So you picked them up? Why you did not notify anyone? b4 does it almost automatically. How anyone can know what is happening with the patches? I will drop them from my tree. Best regards, Krzysztof
On 24/04/2024 09:23, Krzysztof Kozlowski wrote: > On 24/04/2024 09:16, Wei Xu wrote: >> Hi Krzysztof, >> >> On 2024/4/24 14:54, Krzysztof Kozlowski wrote: >>> >>> On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: >>>> Non-MMIO devices, which are BTW not really part of the SoC, should not >>>> be within simple-bus, as reported by dtc W=1 warning: >>>> >>>> hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property >>>> >>>> >>> >>> Almost a month passed, no replies from maintainers about picking it up. Dunno, >>> looks abandoned, so let me grab this. If anyone else wants to pick it up, let >>> me know. >>> >> >> Sorry for the late reply! >> I am applying these patches which are in the following git repo. >> https://github.com/hisilicon/linux-hisi/tree/next/dt64 >> >> And it is fine to me to go through your git tree. >> Thanks! > > So you picked them up? Why you did not notify anyone? b4 does it almost > automatically. How anyone can know what is happening with the patches? > > I will drop them from my tree. One more thing: Even though you applied these patches few days ago, they are still not in linux-next (as of next-20240423), which suggests your tree is not in next. Please read entire presentation "Beginner Linux kernel maintainer's toolbox" from LPC 2023 and improve your workflow by: 1. Properly notifying patch status. 2. Being part of the integration tree. 3. ... and more, as explained in above talk. There is a link to video and slides: https://lpc.events/event/17/contributions/1498/ Best regards, Krzysztof
Hi Krzysztof, On 2024/4/24 16:37, Krzysztof Kozlowski wrote: > On 24/04/2024 09:23, Krzysztof Kozlowski wrote: >> On 24/04/2024 09:16, Wei Xu wrote: >>> Hi Krzysztof, >>> >>> On 2024/4/24 14:54, Krzysztof Kozlowski wrote: >>>> >>>> On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: >>>>> Non-MMIO devices, which are BTW not really part of the SoC, should not >>>>> be within simple-bus, as reported by dtc W=1 warning: >>>>> >>>>> hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property >>>>> >>>>> >>>> >>>> Almost a month passed, no replies from maintainers about picking it up. Dunno, >>>> looks abandoned, so let me grab this. If anyone else wants to pick it up, let >>>> me know. >>>> >>> >>> Sorry for the late reply! >>> I am applying these patches which are in the following git repo. >>> https://github.com/hisilicon/linux-hisi/tree/next/dt64 >>> >>> And it is fine to me to go through your git tree. >>> Thanks! >> >> So you picked them up? Why you did not notify anyone? b4 does it almost >> automatically. How anyone can know what is happening with the patches? >> >> I will drop them from my tree. OK. I will pick up them. > > One more thing: > > Even though you applied these patches few days ago, they are still not > in linux-next (as of next-20240423), which suggests your tree is not in > next. > > Please read entire presentation "Beginner Linux kernel maintainer's > toolbox" from LPC 2023 and improve your workflow by: > 1. Properly notifying patch status. > 2. Being part of the integration tree. > 3. ... and more, as explained in above talk. > > There is a link to video and slides: > https://lpc.events/event/17/contributions/1498/ Got it.Thanks! I will go through it. Best Regards, Wei > > Best regards, > Krzysztof > > . >
Hi Krzysztof, On 2024/4/24 16:37, Krzysztof Kozlowski wrote: > On 24/04/2024 09:23, Krzysztof Kozlowski wrote: >> On 24/04/2024 09:16, Wei Xu wrote: >>> Hi Krzysztof, >>> >>> On 2024/4/24 14:54, Krzysztof Kozlowski wrote: >>>> >>>> On Tue, 02 Apr 2024 21:31:40 +0200, Krzysztof Kozlowski wrote: >>>>> Non-MMIO devices, which are BTW not really part of the SoC, should not >>>>> be within simple-bus, as reported by dtc W=1 warning: >>>>> >>>>> hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property >>>>> >>>>> >>>> >>>> Almost a month passed, no replies from maintainers about picking it up. Dunno, >>>> looks abandoned, so let me grab this. If anyone else wants to pick it up, let >>>> me know. >>>> >>> >>> Sorry for the late reply! >>> I am applying these patches which are in the following git repo. >>> https://github.com/hisilicon/linux-hisi/tree/next/dt64 >>> >>> And it is fine to me to go through your git tree. >>> Thanks! >> >> So you picked them up? Why you did not notify anyone? b4 does it almost >> automatically. How anyone can know what is happening with the patches? >> >> I will drop them from my tree. Series applied to the HiSilicon arm64 dt tree: https://github.com/hisilicon/linux-hisi/tree/next/dt64 > > One more thing: > > Even though you applied these patches few days ago, they are still not > in linux-next (as of next-20240423), which suggests your tree is not in > next. > > Please read entire presentation "Beginner Linux kernel maintainer's > toolbox" from LPC 2023 and improve your workflow by: > 1. Properly notifying patch status. > 2. Being part of the integration tree. > 3. ... and more, as explained in above talk. > > There is a link to video and slides: > https://lpc.events/event/17/contributions/1498/ I have went through your slide which is very helpful and detailed. Thanks! Best Regards, Wei > > Best regards, > Krzysztof > > . >
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi index 65ddc0698f82..d0912ca5f237 100644 --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi @@ -279,6 +279,12 @@ its_dsa: msi-controller@c6000000 { }; }; + refclk200mhz: refclk200mhz { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <200000000>; + }; + timer { compatible = "arm,armv8-timer"; interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, @@ -298,12 +304,6 @@ soc { #size-cells = <2>; ranges; - refclk200mhz: refclk200mhz { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <200000000>; - }; - uart0: serial@80300000 { compatible = "snps,dw-apb-uart"; reg = <0x0 0x80300000 0x0 0x10000>;
Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning: hip05.dtsi:301.30-305.5: Warning (simple_bus_reg): /soc/refclk200mhz: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/hisilicon/hip05.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)