diff mbox series

[v1,2/4] dt-bindings: arm: fsl: remove reduntant toradex,colibri-imx8x

Message ID 20240402193512.240417-3-hiagofranco@gmail.com (mailing list archive)
State New
Headers show
Series arm64: dts: freescale: Add Toradex Colibri iMX8DX | expand

Commit Message

Hiago De Franco April 2, 2024, 7:35 p.m. UTC 
From: Hiago De Franco <hiago.franco@toradex.com>

'toradex,colibri-imx8x' is already present as a constant value for
'i.MX8QP Board with Toradex Colibri iMX8X Modules', so there is no need
to keep it twice as a enum value for 'i.MX8QXP based Boards'.

Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
 1 file changed, 1 deletion(-)

Comments

Rob Herring (Arm) April 3, 2024, 4:57 p.m. UTC | #1 
On Tue, Apr 02, 2024 at 04:35:10PM -0300, Hiago De Franco wrote:
> From: Hiago De Franco <hiago.franco@toradex.com>
> 
> 'toradex,colibri-imx8x' is already present as a constant value for
> 'i.MX8QP Board with Toradex Colibri iMX8X Modules', so there is no need
> to keep it twice as a enum value for 'i.MX8QXP based Boards'.

If the module can operate on its own, then it would be valid to have 
just "toradex,colibri-imx8x". If not, then:

Acked-by: Rob Herring <robh@kernel.org>

> 
> Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0027201e19f8..6fdfa10af43c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1218,7 +1218,6 @@ properties:
>            - enum:
>                - einfochips,imx8qxp-ai_ml  # i.MX8QXP AI_ML Board
>                - fsl,imx8qxp-mek           # i.MX8QXP MEK Board
> -              - toradex,colibri-imx8x     # Colibri iMX8X Modules
>            - const: fsl,imx8qxp
>  
>        - description: i.MX8DXL based Boards
> -- 
> 2.39.2
>
Francesco Dolcini April 4, 2024, 8:02 a.m. UTC | #2 
Hello Rob,

On Wed, Apr 03, 2024 at 11:57:21AM -0500, Rob Herring wrote:
> On Tue, Apr 02, 2024 at 04:35:10PM -0300, Hiago De Franco wrote:
> > From: Hiago De Franco <hiago.franco@toradex.com>
> > 
> > 'toradex,colibri-imx8x' is already present as a constant value for
> > 'i.MX8QP Board with Toradex Colibri iMX8X Modules', so there is no need
> > to keep it twice as a enum value for 'i.MX8QXP based Boards'.
> 
> If the module can operate on its own

For the records, it can't.

> Acked-by: Rob Herring <robh@kernel.org>

Thanks,
Francesco
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0027201e19f8..6fdfa10af43c 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1218,7 +1218,6 @@  properties:
           - enum:
               - einfochips,imx8qxp-ai_ml  # i.MX8QXP AI_ML Board
               - fsl,imx8qxp-mek           # i.MX8QXP MEK Board
-              - toradex,colibri-imx8x     # Colibri iMX8X Modules
           - const: fsl,imx8qxp
 
       - description: i.MX8DXL based Boards