| Message ID | 20240403-fix-dw-hdmi-kconfig-v1-1-afbc4a835c38@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/display: Fix display helpers depends on fallouts | expand |
On Wed, 03 Apr 2024 12:56:19 +0200, Maxime Ripard wrote: > The DisplayPort helpers rely on some > (__drm_atomic_helper_private_obj_duplicate_state, > drm_kms_helper_hotplug_event) helpers found in files compiled by > DRM_KMS_HELPER. > > Prior to commit d674858ff979 ("drm/display: Make all helpers visible and > switch to depends on"), DRM_DISPLAY_DP_HELPER was only selectable so it > wasn't really a big deal. However, since that commit, it's now something > that can be enabled as is, and since there's no expressed dependency > with DRM_KMS_HELPER, it can break too. > > [...] Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime
diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig index 01f2a231aa5f..a38962a556c2 100644 --- a/drivers/gpu/drm/display/Kconfig +++ b/drivers/gpu/drm/display/Kconfig @@ -37,10 +37,11 @@ config DRM_DISPLAY_DP_AUX_CHARDEV channel. config DRM_DISPLAY_DP_HELPER bool "DRM DisplayPort Helpers" depends on DRM_DISPLAY_HELPER + select DRM_KMS_HELPER default y help DRM display helpers for DisplayPort. config DRM_DISPLAY_DP_TUNNEL
The DisplayPort helpers rely on some (__drm_atomic_helper_private_obj_duplicate_state, drm_kms_helper_hotplug_event) helpers found in files compiled by DRM_KMS_HELPER. Prior to commit d674858ff979 ("drm/display: Make all helpers visible and switch to depends on"), DRM_DISPLAY_DP_HELPER was only selectable so it wasn't really a big deal. However, since that commit, it's now something that can be enabled as is, and since there's no expressed dependency with DRM_KMS_HELPER, it can break too. Since DRM_KMS_HELPER is a selectable option for now, let's select it for DRM_DISPLAY_DP_HELPER. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404021556.0JVcNC13-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202404021700.LbyYZGFd-lkp@intel.com/ Fixes: d674858ff979 ("drm/display: Make all helpers visible and switch to depends on") Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/display/Kconfig | 1 + 1 file changed, 1 insertion(+)