| Message ID | 20240403102302.3934932-1-mwalle@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] arm64: dts: ti: k3-j722s-evm: Enable eMMC support | expand |
Hello Michael, On Wed, Apr 03, 2024 at 12:23:02PM +0200, Michael Walle wrote: > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. > There is no pinmuxing required because the interface has dedicated pins. > > Signed-off-by: Michael Walle <mwalle@kernel.org> > --- > v2: > - move status="okay" last > --- > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > index cee3a8661d5e..6b148da2bcdc 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > @@ -369,6 +369,13 @@ partition@3fc0000 { > > }; > > +&sdhci0 { > + ti,driver-strength-ohm = <50>; According to the latest DTS coding style guidelines this needs to be just before status. https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Yes, we would need a checker, I know and I agree. At least now we moved out of the tribal knowledge way of working with every maintainer having slightly different expectation on this topic ... one step at a time :-) > + disable-wp; > + bootph-all; > + status = "okay"; > +}; Francesco
On 09:45-20240404, Francesco Dolcini wrote: > Hello Michael, > > On Wed, Apr 03, 2024 at 12:23:02PM +0200, Michael Walle wrote: > > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. > > There is no pinmuxing required because the interface has dedicated pins. > > > > Signed-off-by: Michael Walle <mwalle@kernel.org> > > --- > > v2: > > - move status="okay" last > > --- > > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > > index cee3a8661d5e..6b148da2bcdc 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts > > @@ -369,6 +369,13 @@ partition@3fc0000 { > > > > }; > > > > +&sdhci0 { > > + ti,driver-strength-ohm = <50>; > > According to the latest DTS coding style guidelines this needs to be > just before status. > > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node > > Yes, we would need a checker, I know and I agree. At least now we moved > out of the tribal knowledge way of working with every maintainer having > slightly different expectation on this topic ... one step at a time :-) Since this is the first cycle, I have done this fixup locally.
Hi Michael Walle, On Wed, 03 Apr 2024 12:23:02 +0200, Michael Walle wrote: > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. > There is no pinmuxing required because the interface has dedicated pins. > > I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/1] arm64: dts: ti: k3-j722s-evm: Enable eMMC support commit: ab833a6478e5376f8076be41109d74387ab8460e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts index cee3a8661d5e..6b148da2bcdc 100644 --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts @@ -369,6 +369,13 @@ partition@3fc0000 { }; +&sdhci0 { + ti,driver-strength-ohm = <50>; + disable-wp; + bootph-all; + status = "okay"; +}; + &sdhci1 { /* SD/MMC */ vmmc-supply = <&vdd_mmc1>;
The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. There is no pinmuxing required because the interface has dedicated pins. Signed-off-by: Michael Walle <mwalle@kernel.org> --- v2: - move status="okay" last --- arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++ 1 file changed, 7 insertions(+)