| Message ID | 20240403102701.369-2-shawn.sung@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add mediate-drm secure flow for SVP | expand |
Hi, On Wed, Apr 03, 2024 at 06:26:53PM +0800, Shawn Sung wrote: > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com> > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate > a secure buffer to support secure video path feature. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > include/uapi/drm/mediatek_drm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/drm/mediatek_drm.h b/include/uapi/drm/mediatek_drm.h > index b0dea00bacbc4..e9125de3a24ad 100644 > --- a/include/uapi/drm/mediatek_drm.h > +++ b/include/uapi/drm/mediatek_drm.h > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { > > #define DRM_MTK_GEM_CREATE 0x00 > #define DRM_MTK_GEM_MAP_OFFSET 0x01 > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 > > #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ > DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create) That flag doesn't exist in drm-misc-next, which tree is this based on? Maxime
Hi, Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit : > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com> > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate Is "ENCRYPTED" a proper naming ? My expectation is that this would hold data in a PROTECTED memory region but that no cryptographic algorithm will be involved. Nicolas > a secure buffer to support secure video path feature. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > include/uapi/drm/mediatek_drm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/drm/mediatek_drm.h b/include/uapi/drm/mediatek_drm.h > index b0dea00bacbc4..e9125de3a24ad 100644 > --- a/include/uapi/drm/mediatek_drm.h > +++ b/include/uapi/drm/mediatek_drm.h > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { > > #define DRM_MTK_GEM_CREATE 0x00 > #define DRM_MTK_GEM_MAP_OFFSET 0x01 > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 > > #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ > DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create)
I would argue 'restricted' is the proper name since that was what was settled on for the dma-buf code. :) But you are definitely right that this memory is not encrypted. On Tue, Apr 16, 2024 at 7:09 AM Nicolas Dufresne <nicolas@ndufresne.ca> wrote: > > Hi, > > Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit : > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com> > > > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate > > Is "ENCRYPTED" a proper naming ? My expectation is that this would hold data in > a PROTECTED memory region but that no cryptographic algorithm will be involved. > > Nicolas > > > a secure buffer to support secure video path feature. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > --- > > include/uapi/drm/mediatek_drm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/uapi/drm/mediatek_drm.h b/include/uapi/drm/mediatek_drm.h > > index b0dea00bacbc4..e9125de3a24ad 100644 > > --- a/include/uapi/drm/mediatek_drm.h > > +++ b/include/uapi/drm/mediatek_drm.h > > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { > > > > #define DRM_MTK_GEM_CREATE 0x00 > > #define DRM_MTK_GEM_MAP_OFFSET 0x01 > > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 > > > > #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ > > DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create) > >
On Mon, 2024-04-15 at 11:32 +0200, Maxime Ripard wrote: > Hi, > > On Wed, Apr 03, 2024 at 06:26:53PM +0800, Shawn Sung wrote: > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com> > > > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate > > a secure buffer to support secure video path feature. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > --- > > include/uapi/drm/mediatek_drm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/uapi/drm/mediatek_drm.h > > b/include/uapi/drm/mediatek_drm.h > > index b0dea00bacbc4..e9125de3a24ad 100644 > > --- a/include/uapi/drm/mediatek_drm.h > > +++ b/include/uapi/drm/mediatek_drm.h > > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { > > > > #define DRM_MTK_GEM_CREATE 0x00 > > #define DRM_MTK_GEM_MAP_OFFSET 0x01 > > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 > > > > #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ > > DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create) > > That flag doesn't exist in drm-misc-next, which tree is this based > on? > I think we missed the patch [1] in this series. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20240403102602.32155-11-shawn.sung@mediatek.com/ I'll add it back at the next version. Regards, Jason-JH.Lin > Maxime
On Tue, 2024-04-16 at 10:19 -0700, Jeffrey Kardatzke wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > I would argue 'restricted' is the proper name since that was what > was > settled on for the dma-buf code. :) But you are definitely right > that this memory is not encrypted. > > > On Tue, Apr 16, 2024 at 7:09 AM Nicolas Dufresne < > nicolas@ndufresne.ca> wrote: > > > > Hi, > > > > Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit : > > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com> > > > > > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate > > > > Is "ENCRYPTED" a proper naming ? My expectation is that this would > hold data in > > a PROTECTED memory region but that no cryptographic algorithm will > be involved. > > > > Nicolas > > > > > a secure buffer to support secure video path feature. > > > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > > > --- > > > include/uapi/drm/mediatek_drm.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/uapi/drm/mediatek_drm.h > b/include/uapi/drm/mediatek_drm.h > > > index b0dea00bacbc4..e9125de3a24ad 100644 > > > --- a/include/uapi/drm/mediatek_drm.h > > > +++ b/include/uapi/drm/mediatek_drm.h > > > @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { > > > > > > #define DRM_MTK_GEM_CREATE 0x00 > > > #define DRM_MTK_GEM_MAP_OFFSET 0x01 > > > +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 OK, I'll change this to DRM_MTK_GEM_CREATE_RESTRICTED at the next version. Regards, Jason-JH.Lin > > > > > > #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + > \ > > > DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create) > > > >
diff --git a/include/uapi/drm/mediatek_drm.h b/include/uapi/drm/mediatek_drm.h index b0dea00bacbc4..e9125de3a24ad 100644 --- a/include/uapi/drm/mediatek_drm.h +++ b/include/uapi/drm/mediatek_drm.h @@ -54,6 +54,7 @@ struct drm_mtk_gem_map_off { #define DRM_MTK_GEM_CREATE 0x00 #define DRM_MTK_GEM_MAP_OFFSET 0x01 +#define DRM_MTK_GEM_CREATE_ENCRYPTED 0x02 #define DRM_IOCTL_MTK_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ DRM_MTK_GEM_CREATE, struct drm_mtk_gem_create)