| Message ID | 20240410070128.1506555-2-joy.zou@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add rtc PCF2131 support | expand |
On 24-04-10, Joy Zou wrote: > Support rtc PCF2131 on imx93-11x11-evk. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > Changes in v3: > 1.adjust the indentation. > > Changes in v2: > 1. remove unnecessary status property. > --- > .../boot/dts/freescale/imx93-11x11-evk.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > index 07e85a30a25f..73e0bca36b81 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > @@ -281,6 +281,23 @@ ldo5: LDO5 { > }; > }; > > +&lpi2c3 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_lpi2c3>; > + pinctrl-1 = <&pinctrl_lpi2c3>; Are both "default" and "sleep" pinctrl's required? It doesn't make any sense to provde a sleep state which uses the same pinctrl state. Regards, Marco > + status = "okay"; > + > + pcf2131: rtc@53 { > + compatible = "nxp,pcf2131"; > + reg = <0x53>; > + interrupt-parent = <&pcal6524>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; > + > &iomuxc { > pinctrl_eqos: eqosgrp { > fsl,pins = < > @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e > >; > }; > > + pinctrl_lpi2c3: lpi2c3grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e > + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e > + >; > + }; > + > pinctrl_pcal6524: pcal6524grp { > fsl,pins = < > MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e > -- > 2.37.1 > > >
> -----Original Message----- > From: Marco Felsch <m.felsch@pengutronix.de> > Sent: 2024年4月10日 15:40 > To: Joy Zou <joy.zou@nxp.com> > Cc: Jacky Bai <ping.bai@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; devicetree@vger.kernel.org; > imx@lists.linux.dev; linux-kernel@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com>; kernel@pengutronix.de; festevam@gmail.com; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc > PCF2131 support > On 24-04-10, Joy Zou wrote: > > Support rtc PCF2131 on imx93-11x11-evk. > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > --- > > Changes in v3: > > 1.adjust the indentation. > > > > Changes in v2: > > 1. remove unnecessary status property. > > --- > > .../boot/dts/freescale/imx93-11x11-evk.dts | 24 > +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > index 07e85a30a25f..73e0bca36b81 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > @@ -281,6 +281,23 @@ ldo5: LDO5 { > > }; > > }; > > > > +&lpi2c3 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clock-frequency = <400000>; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&pinctrl_lpi2c3>; > > + pinctrl-1 = <&pinctrl_lpi2c3>; > > Are both "default" and "sleep" pinctrl's required? It doesn't make any sense > to provde a sleep state which uses the same pinctrl state. Thanks for your comments! Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state. So will remove the sleep. BR Joy Zou > > Regards, > Marco >
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts index 07e85a30a25f..73e0bca36b81 100644 --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts @@ -281,6 +281,23 @@ ldo5: LDO5 { }; }; +&lpi2c3 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <400000>; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&pinctrl_lpi2c3>; + pinctrl-1 = <&pinctrl_lpi2c3>; + status = "okay"; + + pcf2131: rtc@53 { + compatible = "nxp,pcf2131"; + reg = <0x53>; + interrupt-parent = <&pcal6524>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; + }; +}; + &iomuxc { pinctrl_eqos: eqosgrp { fsl,pins = < @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e >; }; + pinctrl_lpi2c3: lpi2c3grp { + fsl,pins = < + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e + >; + }; + pinctrl_pcal6524: pcal6524grp { fsl,pins = < MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e
Support rtc PCF2131 on imx93-11x11-evk. Signed-off-by: Joy Zou <joy.zou@nxp.com> --- Changes in v3: 1.adjust the indentation. Changes in v2: 1. remove unnecessary status property. --- .../boot/dts/freescale/imx93-11x11-evk.dts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)