From patchwork Fri Apr 12 14:22:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D53C4345F for ; Fri, 12 Apr 2024 14:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wj7qX2XaEiq5rtDI+XA2kCVTSG2Hr2Hnc6lE3dIFO9I=; b=h0ABh+qImPkb3y Y80KeI7s6o84xwKMbyHR25hQ1ICGJoa8/J177Ec5yxBTAAmSx/k/EVJUKLLE+4DNjAHn0AZD6cOgQ w8WU8xK3Vbcbzc4YA1LlH2sQLJDIy4q2QNl0yCuLbzg7i7QkPXsPJK/IX1NhXTHrw5KmdqUWuOcjj wHoxEQKY0kiUOwnJ66QYZcwzcbTANwfVn9OQzXrWxnJ7wpEq6J5Aaj2sOkjtQd/ogvBh0JbCT7wFX Ji/BWdaVMxD84UWrrz1Gb5zA7LUSH0cq4Ol8t4vuu1nmGHNwGwflETE7f9InOTZHjgehnSn0m9QRA trAjreytC1o+gg1wpntw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHow-0000000HXuW-3LCu; Fri, 12 Apr 2024 14:24:02 +0000 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHot-0000000HXr1-0Xf0 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:24:01 +0000 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-22ed72b0082so604036fac.3 for ; Fri, 12 Apr 2024 07:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931836; x=1713536636; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rnop7Tz3u3A6Y7l9rLZDgV358HdsfnR1FGKtIeVuKBc=; b=OT566YI17lZEz8wA2NveK1wkIYNTshp4yY7isrNVEMI1GjlZVif7uTuSuxSf7zDoYL shUtb0siTWwACUJejv5QmN2F1VcDkU32IYnvFWcVexeDutwqoMYs58i77h0O7GwSNJtM wlT3ZHq6n7Z3MwqfiC5c/KGAQIUa0sfhFtIf9UWgjHkR8COE6yNRLXdSN94KRbkK9h1s Ep/kcems6F088vg9eHBnZkhZgA5qvRaAwNZqf+pn28+MJw8Ckdx17riHWwD+19Lk0bNM Kwfa52zSUetUJl8I4nZBKIjb3bJSanYDwpMcjh6bo1RzBeivGBmF9HT7m7g/j5HRsyVP IF0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931836; x=1713536636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rnop7Tz3u3A6Y7l9rLZDgV358HdsfnR1FGKtIeVuKBc=; b=mjIUjw+UEbFbSfQNlSC7a9lb9ox9xAN1WfgeJ6ffYp5xP0AXys9/zCmVEtroja261f 9Ebx6uScdcncIv6sguZH4f55VnwIU27jAjDug8cdzeN2NIgwpW/dl+u/BhA1Un4eo/xp 8RlOGNy2MLtYxQg9oWyf+Uu0X3lY8fmU44sz31ls2ARrvvw9XH5NeytC/3qjpuBJumJg m9UMcYozjaDQBICpIa6jd6mymAXfRqI2INcPkivVdv0a6I9CleA24Pn66qL/ktaQeYni j+WXxUTEehRp8wNyraXUDJU1HU0hpcFkGnFX//A+4K5WjQIfhZEnIdLns32g0v1Rdj82 Q+bQ== X-Forwarded-Encrypted: i=1; AJvYcCVppHcNTiRN2iThNCxMiG6nTlExcXdP3g5dGYbFIex1b1a5Ib1k7IJatGg0RnLgep4Zt7UyQhaKpLKMclJ6PhQQFYj50025NMD+I68iUCWcRs4sJBs= X-Gm-Message-State: AOJu0YzDpBRcgAfEfPCyDffPoVXy4jN4rusAst/bOksPKxdKrmzWHZKS z+W90ff4xfBqXjWmGr3sFaLwbGaejnXgFQrlNKABQkoiJxZ+T+2eibKFLg== X-Google-Smtp-Source: AGHT+IESH4fkXQOzELFKbwow3I/3zmYaBjB31FBeox2i7Lpcl/4hma+H6YA6EljsfIfiVAabwskJIQ== X-Received: by 2002:a05:6870:4194:b0:22a:f96:28b3 with SMTP id y20-20020a056870419400b0022a0f9628b3mr3085006oac.53.1712931836388; Fri, 12 Apr 2024 07:23:56 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:23:56 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/5] usb: ohci-exynos: Use devm_clk_get_enabled() helpers Date: Fri, 12 Apr 2024 19:52:52 +0530 Message-ID: <20240412142317.5191-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072359_273643_EF0AA331 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: Anand Moon --- v3: drop dev_err_probe to simplify the error handle. v2: new patch in this series --- drivers/usb/host/ohci-exynos.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 20e26a474591..89e6587c089b 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -135,20 +135,16 @@ static int exynos_ohci_probe(struct platform_device *pdev) err = exynos_ohci_get_phy(&pdev->dev, exynos_ohci); if (err) - goto fail_clk; + goto fail_io; - exynos_ohci->clk = devm_clk_get(&pdev->dev, "usbhost"); + exynos_ohci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost"); if (IS_ERR(exynos_ohci->clk)) { dev_err(&pdev->dev, "Failed to get usbhost clock\n"); err = PTR_ERR(exynos_ohci->clk); - goto fail_clk; + goto fail_io; } - err = clk_prepare_enable(exynos_ohci->clk); - if (err) - goto fail_clk; - hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hcd->regs)) { err = PTR_ERR(hcd->regs); @@ -191,8 +187,6 @@ static int exynos_ohci_probe(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); pdev->dev.of_node = exynos_ohci->of_node; fail_io: - clk_disable_unprepare(exynos_ohci->clk); -fail_clk: usb_put_hcd(hcd); return err; } @@ -208,8 +202,6 @@ static void exynos_ohci_remove(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); - clk_disable_unprepare(exynos_ohci->clk); - usb_put_hcd(hcd); }