From patchwork Mon Apr 15 19:34:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13630650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D5DFC4345F for ; Mon, 15 Apr 2024 19:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJ2rBKHL7wOaYncrZIVfTfmKcDA9jKOLyhp/8FUWGkI=; b=lszzjpsUR5khxW mlKkIFGqWjV2e4hBuXrkgr0PqxxIculmPFwYdk0m1yrZfMOg71+pa5un2RFlIRiqqP0RHcDvALXxu rn2zWvoSUGpqBwl9nVuYTOiGH/ni+K//nLqSGz0igS4qzve/M4fbYaJSyNsD4ITH8RwmHDWYb4keP of8gxP6IJzsagVv6po5pgmLXHLQMMqTOxOw6tR2D6Kkg6s38Hxm+A3BpIk/KhPCt47atHmccICVZM oebb1DwH82pqQ+F4LG476Zs73pl4Oydfw4/SM6NJhuG86PaEKDznOKsPRj7ffPzkReTpw129dFY01 sRWjbi/ODeACeP7swdPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwSBg-00000009fRj-0rdO; Mon, 15 Apr 2024 19:40:20 +0000 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwS6a-00000009cHb-08BN for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 19:35:06 +0000 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-617e6c873f3so39447357b3.2 for ; Mon, 15 Apr 2024 12:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713209702; x=1713814502; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jt2XKVmYwRsbqiFBuUwX1RfD+QA2xOHKpcd2HjFMj/E=; b=jrF5pB0QD9pdnoxhteeXkSUCvzAOGK/XKQtYCY+JfPJCEUdzyFq5fgpAZhdci9edKT HyaduLAkzCsdYnRAl+VvwOjEHru5r4Yp8wh/xoPjTLfyAz/G5EysIrKgcP7xERG9+vGQ 2PVYwu9b+0yf6nrcXBIY3ZzPB0G55DqnuclM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713209702; x=1713814502; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jt2XKVmYwRsbqiFBuUwX1RfD+QA2xOHKpcd2HjFMj/E=; b=SY8ucLKb9LcpiMCs+IrAgVFMFl3Fi6dQt8whpP6151wIzyd8nYFXr408puuA//Bfrc mMzteYuJij2EiG8san6y0U6LJCVegFLEzwW3oF0ktKYuCeKku7CpyIQ5N91C0AkX7vBk wu10GWOa9Nxc47uvsKS5N21/krD1KnV4SsD02KBmrf0oOBUDwxwOn67fX1qE3yQH2QlK Ib+oMxhRYMZi9CUUZZu71raLNH/LinKNBUFHpj7klZUUs1JX5oRlty2mdyH6uLheedJ3 HIB32oZcGd3vcBY/9gr1FyMIajlvMzmfnm5pRmulEGR041k0bMyXYmalZwwCw+4zFSN9 44DA== X-Forwarded-Encrypted: i=1; AJvYcCUYaQQYwpchxD7CLup9DStlsDi7oLqw7FzyhPKjGj0uWjQYsghg9s56NAe3I+QjLNFXzbGE+XdiFlUdwxgS7DZ5iERC+RUGCO1vrNh/rS8Osm4BRtM= X-Gm-Message-State: AOJu0YwlS9rP9/cAK4O9f/I9vIvsNZxic3wEAFBh5pKNBBp2gSWZgXYz sExKDxKYN15a3QYW2x5HF8zvWK2ID0OrZ1+x3DG3nrcDprNSuwNCNL/JQrbTcA== X-Google-Smtp-Source: AGHT+IEHr8lEllDyip6pAkUMGURPdINr08Mt5MZfIhMi3nIR8h+wyIaxQ16q8BBaKyR8INXB42ugWw== X-Received: by 2002:a0d:e292:0:b0:615:2078:9c0b with SMTP id l140-20020a0de292000000b0061520789c0bmr10298321ywe.40.1713209701695; Mon, 15 Apr 2024 12:35:01 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id s26-20020ae9f71a000000b0078d3b54eb76sm6718055qkg.78.2024.04.15.12.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 12:35:01 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 15 Apr 2024 19:34:47 +0000 Subject: [PATCH 30/35] media: i2c: et8ek8: Refator return path MIME-Version: 1.0 Message-Id: <20240415-fix-cocci-v1-30-477afb23728b@chromium.org> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_123504_240735_3779D183 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a nop, but let cocci now that this is not a good candidate for min() drivers/media/i2c/et8ek8/et8ek8_driver.c:255:13-14: WARNING opportunity for min() Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index e932d25ca7b3..c7984f90ae4d 100644 --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c @@ -252,7 +252,9 @@ static int et8ek8_i2c_buffered_write_regs(struct i2c_client *client, rval = i2c_transfer(client->adapter, msg, wcnt); - return rval < 0 ? rval : 0; + if (rval < 0) + return rval; + return 0; } /*