| Message ID | 20240415-fix-cocci-v1-6-477afb23728b@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: Fix coccinelle warning/errors | expand |
On Mon, Apr 15, 2024 at 07:34:23PM +0000, Ricardo Ribalda wrote: > platform_get_irq() already prints an error message. > > Found by cocci: > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > index bce821eb71ce..c25027b0ca32 100644 > --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) > "Could not get reset control\n"); > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - if (irq != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Could not get irq\n"); > + if (irq <= 0) > return irq ? irq : -ENXIO; platform_get_irq() can never return zero so this should be written as: irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; There is a comment next to platform_get_irq() which documents this. regards, dan carpenter
diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index bce821eb71ce..c25027b0ca32 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev) "Could not get reset control\n"); irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(&pdev->dev, "Could not get irq\n"); + if (irq <= 0) return irq ? irq : -ENXIO; - } dcmipp->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(dcmipp->regs)) {
platform_get_irq() already prints an error message. Found by cocci: drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 is redundant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)